src/compiler/wasm-compiler.cc - Issue 1700043004: [wasm] Produce debug name in debug builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/wasm-compiler.cc

Issue 1700043004: [wasm] Produce debug name in debug builds. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/wasm-compiler.cc

diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc

index f4373a4e2fee527a1ee71d20a59c93cc9014c00a..b0547584c4ef1d47dc61e4cd74f1e5a105afcf6a 100644

--- a/src/compiler/wasm-compiler.cc

+++ b/src/compiler/wasm-compiler.cc

@@ -2132,6 +2132,9 @@ Handle<Code> CompileWasmFunction(wasm::ErrorThrower& thrower, Isolate* isolate,

Code::Flags flags = Code::ComputeFlags(Code::WASM_FUNCTION);

// add flags here if a meaningful name is helpful for debugging.

bool debugging =

+#if DEBUG

+ true ||

bradnelson 2016/02/17 02:54:21 Seems prone to getting separated, #if #else ?

Mircea Trofin 2016/02/17 03:08:33 Done.

+#endif

FLAG_print_opt_code || FLAG_trace_turbo || FLAG_trace_turbo_graph;

const char* func_name = "wasm";

Vector<char> buffer;

« no previous file with comments | « no previous file | no next file » | no next file with comments »