Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1700043004: [wasm] Produce debug name in debug builds. (Closed)

Created:
4 years, 10 months ago by Mircea Trofin
Modified:
4 years, 10 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com, bradnelson
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Produce debug name in debug builds. BUG= Committed: https://crrev.com/985f67911c3fa535448cb5db3019501353954a11 Cr-Commit-Position: refs/heads/master@{#34052}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/wasm-compiler.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Mircea Trofin
4 years, 10 months ago (2016-02-17 02:43:46 UTC) #3
bradnelson
lgtm, with optional suggestion. https://codereview.chromium.org/1700043004/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/1700043004/diff/1/src/compiler/wasm-compiler.cc#newcode2136 src/compiler/wasm-compiler.cc:2136: true || Seems prone to ...
4 years, 10 months ago (2016-02-17 02:54:21 UTC) #5
Mircea Trofin
https://codereview.chromium.org/1700043004/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/1700043004/diff/1/src/compiler/wasm-compiler.cc#newcode2136 src/compiler/wasm-compiler.cc:2136: true || On 2016/02/17 02:54:21, bradnelson wrote: > Seems ...
4 years, 10 months ago (2016-02-17 03:08:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700043004/20001
4 years, 10 months ago (2016-02-17 03:08:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 03:51:29 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 03:52:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/985f67911c3fa535448cb5db3019501353954a11
Cr-Commit-Position: refs/heads/master@{#34052}

Powered by Google App Engine
This is Rietveld 408576698