Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1700023003: Mark StyleGeneratedImage::m_fixedSize as const (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 10 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark StyleGeneratedImage::m_fixedSize as const Make it obvious that a generated image doesn't go from fixed size to non-fixed size or vice versa during its life time. BUG=581357 Committed: https://crrev.com/f983217921f44ffa4df0c6e715fd351931712f53 Cr-Commit-Position: refs/heads/master@{#375571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700023003/1
4 years, 10 months ago (2016-02-16 13:12:24 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 14:12:40 UTC) #4
davve
4 years, 10 months ago (2016-02-16 14:23:33 UTC) #6
fs
lgtm
4 years, 10 months ago (2016-02-16 14:24:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700023003/1
4 years, 10 months ago (2016-02-16 14:41:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 14:45:49 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:52:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f983217921f44ffa4df0c6e715fd351931712f53
Cr-Commit-Position: refs/heads/master@{#375571}

Powered by Google App Engine
This is Rietveld 408576698