Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1699993002:
[Autofill] Fill fields if they contain a default value. (Closed)
|
Created:
4 years, 10 months ago by Mathieu Modified:
4 years, 10 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Autofill] Fill fields if they contain a default value.
Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load.
BUG=586806
TEST=FormAutofillTest browser_tests
Committed: https://crrev.com/a8a3267d71dc78846d8f60b31d429a1d6845b512
Cr-Commit-Position: refs/heads/master@{#375694}
Patch Set 1 #
Total comments: 3
Patch Set 2 : changed from buh.com #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== [Autofill] Fill fields if they are filled with a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests ========== to ========== [Autofill] Fill fields if they are filled with a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests ==========
mathp@chromium.org changed reviewers: + sebsg@chromium.org
Description was changed from ========== [Autofill] Fill fields if they are filled with a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests ========== to ========== [Autofill] Fill fields if they contain a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests ==========
Hi Seb, What do you think of this? PTAL.
This is nice! It's going to fix a bunch of sites. I don't think the fact that we might replace data filled by the page is a problem because we have the autofill preview to inform the user. Also in my experience, I often change what the site inferred. lgtm.
mathp@chromium.org changed reviewers: + vabr@chromium.org
Hi Vaclav, please have a look!
LGTM, thanks! https://codereview.chromium.org/1699993002/diff/1/chrome/renderer/autofill/fo... File chrome/renderer/autofill/form_autofill_browsertest.cc (right): https://codereview.chromium.org/1699993002/diff/1/chrome/renderer/autofill/fo... chrome/renderer/autofill/form_autofill_browsertest.cc:3985: "<FORM name='TestForm' action='http://buh.com' method='post'>" Bösen & Heinke? :)
Thanks! Submitting. https://codereview.chromium.org/1699993002/diff/1/chrome/renderer/autofill/fo... File chrome/renderer/autofill/form_autofill_browsertest.cc (right): https://codereview.chromium.org/1699993002/diff/1/chrome/renderer/autofill/fo... chrome/renderer/autofill/form_autofill_browsertest.cc:3985: "<FORM name='TestForm' action='http://buh.com' method='post'>" On 2016/02/16 18:12:32, vabr (Chromium) wrote: > Bösen & Heinke? :) wasn't sure if that was a serious comment, so I changed it to abc.com :)
The CQ bit was checked by mathp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org, sebsg@chromium.org Link to the patchset: https://codereview.chromium.org/1699993002/#ps20001 (title: "changed from buh.com")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699993002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to request the patch to try. Please note that binary files are still unsupported at the moment, this is being worked on. Thanks for your patience. Transient error: No JSON object could be decoded
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by mathp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699993002/20001
Message was sent while issue was closed.
Description was changed from ========== [Autofill] Fill fields if they contain a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests ========== to ========== [Autofill] Fill fields if they contain a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Autofill] Fill fields if they contain a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests ========== to ========== [Autofill] Fill fields if they contain a default value. Previously, would only fill empty fields. Now fills fields that are non-empty, but whose values corresponds to the "value" attribute, meaning it's been the same value since page load. BUG=586806 TEST=FormAutofillTest browser_tests Committed: https://crrev.com/a8a3267d71dc78846d8f60b31d429a1d6845b512 Cr-Commit-Position: refs/heads/master@{#375694} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a8a3267d71dc78846d8f60b31d429a1d6845b512 Cr-Commit-Position: refs/heads/master@{#375694}
Message was sent while issue was closed.
https://codereview.chromium.org/1699993002/diff/1/chrome/renderer/autofill/fo... File chrome/renderer/autofill/form_autofill_browsertest.cc (right): https://codereview.chromium.org/1699993002/diff/1/chrome/renderer/autofill/fo... chrome/renderer/autofill/form_autofill_browsertest.cc:3985: "<FORM name='TestForm' action='http://buh.com' method='post'>" On 2016/02/16 20:03:45, Mathieu Perreault wrote: > On 2016/02/16 18:12:32, vabr (Chromium) wrote: > > Bösen & Heinke? :) > > wasn't sure if that was a serious comment, so I changed it to http://abc.com :) I was merely curious, what made you chose Bösen & Heinke homepage as the example, but I had nothing against it (neither I have anything against abc.com). :) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
