Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1699923002: PPC: [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. Port e0129d0f87677722a2cef055e372ab1e805cacf1 Original commit message: Turn the fast case of ArgumentsAccessStub into a new stub FastNewSloppyArgumentsStub, which is similar to the existing FastNewStrictArgumentsStub, although not polished yet, and the slow case always went to the runtime anyway, so we can just directly emit a runtime call there. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/ea08453c7f43aee423a18f27665394c480879d32 Cr-Commit-Position: refs/heads/master@{#34005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -287 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +252 lines, -266 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-15 18:08:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699923002/1
4 years, 10 months ago (2016-02-15 18:09:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 18:41:26 UTC) #5
dstence
lgtm
4 years, 10 months ago (2016-02-15 18:53:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699923002/1
4 years, 10 months ago (2016-02-15 18:57:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 18:59:35 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 19:00:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea08453c7f43aee423a18f27665394c480879d32
Cr-Commit-Position: refs/heads/master@{#34005}

Powered by Google App Engine
This is Rietveld 408576698