Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1699913002:
Make NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors. (Closed)
|
Created:
4 years, 10 months ago by epertoso Modified:
4 years, 10 months ago Reviewers:
*Toon Verwaest CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionMake NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors.
Before this fix, we always ended up calling Runtime_LoadPropertyWithInterceptor, which caused the performance regression reported in http://crbug.com/585764.
BUG=585764
LOG=y
Committed: https://crrev.com/70910752393dc194b948b4aef094233e08a8b49c
Cr-Commit-Position: refs/heads/master@{#34025}
Patch Set 1 #Patch Set 2 : Update. #Messages
Total messages: 19 (10 generated)
epertoso@chromium.org changed reviewers: + verwaest@chromium.org
epertoso@chromium.org changed required reviewers: + verwaest@chromium.org
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699913002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10993)
Description was changed from ========== Make NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors. Before this fix, we always ended up calling Runtime_LoadPropertyWithInterceptor, which caused the performance regression reported in http://crbug.com/585764. BUG=585764 ========== to ========== Make NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors. Before this fix, we always ended up calling Runtime_LoadPropertyWithInterceptor, which caused the performance regression reported in http://crbug.com/585764. BUG=585764 LOG=y ==========
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699913002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by epertoso@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699913002/20001
Message was sent while issue was closed.
Description was changed from ========== Make NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors. Before this fix, we always ended up calling Runtime_LoadPropertyWithInterceptor, which caused the performance regression reported in http://crbug.com/585764. BUG=585764 LOG=y ========== to ========== Make NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors. Before this fix, we always ended up calling Runtime_LoadPropertyWithInterceptor, which caused the performance regression reported in http://crbug.com/585764. BUG=585764 LOG=y ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors. Before this fix, we always ended up calling Runtime_LoadPropertyWithInterceptor, which caused the performance regression reported in http://crbug.com/585764. BUG=585764 LOG=y ========== to ========== Make NamedLoadHandlerCompiler::CompileLoadInterceptor behave correcly with lazy accessors. Before this fix, we always ended up calling Runtime_LoadPropertyWithInterceptor, which caused the performance regression reported in http://crbug.com/585764. BUG=585764 LOG=y Committed: https://crrev.com/70910752393dc194b948b4aef094233e08a8b49c Cr-Commit-Position: refs/heads/master@{#34025} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/70910752393dc194b948b4aef094233e08a8b49c Cr-Commit-Position: refs/heads/master@{#34025} |
