Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp

Issue 1699893003: setOrientTo{Auto|Angle} should reflect on orient attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align with review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp b/third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp
index fe0e9a4b7ec3bf3978e09526ae4d09cbeb96b015..fe1c8222a2f818aec6f0537d24aebe56b7432e16 100644
--- a/third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp
@@ -116,18 +116,14 @@ void SVGMarkerElement::childrenChanged(const ChildrenChange& change)
void SVGMarkerElement::setOrientToAuto()
{
- m_orientAngle->baseValue()->orientType()->setEnumValue(SVGMarkerOrientAuto);
- invalidateSVGAttributes();
- svgAttributeBaseValChanged(SVGNames::orientAttr);
+ setAttribute(SVGNames::orientAttr, "auto");
}
void SVGMarkerElement::setOrientToAngle(PassRefPtrWillBeRawPtr<SVGAngleTearOff> angle)
{
ASSERT(angle);
RefPtrWillBeRawPtr<SVGAngle> target = angle->target();
- m_orientAngle->baseValue()->newValueSpecifiedUnits(target->unitType(), target->valueInSpecifiedUnits());
- invalidateSVGAttributes();
- svgAttributeBaseValChanged(SVGNames::orientAttr);
+ setAttribute(SVGNames::orientAttr, AtomicString(target->valueAsString()));
}
LayoutObject* SVGMarkerElement::createLayoutObject(const ComputedStyle&)
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698