third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html - Issue 1699893003: setOrientTo{Auto|Angle} should reflect on orient attribute

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html

Issue 1699893003: setOrientTo{Auto|Angle} should reflect on orient attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 test(function() {

	6 var svgElement = document.createElementNS("http://www.w3.org/2000/svg","svg" );

	7 var markerElement = document.createElementNS("http://www.w3.org/2000/svg","m arker");

	8 var svgAngle = svgElement.createSVGAngle();

	9 svgAngle.value = 10;

	10 markerElement.setOrientToAngle(svgAngle);

	11 assert_equals(markerElement.getAttribute("orient"), "10");

	12 }, "Tests with setOrientToAngle");
	fs 2016/02/22 11:43:31 Maybe more descriptive as "getAttribute('orient') Maybe more descriptive as "getAttribute('orient') after setOrientToAngle" or similar. (Since that's what's being tested, and "Tests" is kind of left "hanging".) Shanmuga Pandi 2016/02/22 11:50:09 Done. Show quoted text On 2016/02/22 11:43:31, fs wrote: > Maybe more descriptive as "getAttribute('orient') after setOrientToAngle" or > similar. (Since that's what's being tested, and "Tests" is kind of left > "hanging".) Done.
	13

	14 test(function() {

	15 var markerElement = document.createElementNS("http://www.w3.org/2000/svg","m arker");

	16 markerElement.setOrientToAuto();

	17 assert_equals(markerElement.getAttribute("orient"), "auto");

	18 }, "Tests with setOrientToAuto");
	fs 2016/02/22 11:43:31 Ditto. Ditto. Shanmuga Pandi 2016/02/22 11:50:09 Done. Show quoted text On 2016/02/22 11:43:31, fs wrote: > Ditto. Done.
	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp » ('j') | no next file with comments »