Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 1699833002: dart2js cps: Specialize shift-right calls. (Closed)

Created:
4 years, 10 months ago by asgerf
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Specialize shift-right calls. Call _shrBothPositive, _shrReceiverPositive, or _shrOtherPositive if the receiver and/or argument is known to be a UInt. This matches what the SSA backend does. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/95d4f72bba44a98fcd4d31d642f86dd361bf9aeb

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 chunks +30 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years, 10 months ago (2016-02-15 13:25:43 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years, 10 months ago (2016-02-16 16:44:49 UTC) #4
asgerf
4 years, 10 months ago (2016-02-17 12:58:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
95d4f72bba44a98fcd4d31d642f86dd361bf9aeb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698