Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699793002: [wasm] Clean up some DCHECKS in asm->wasm. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
aseemgarg, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Clean up some DCHECKS in asm->wasm. R=ahaas@chromium.org,aseemgarg@chromium.org BUG= Committed: https://crrev.com/4bce03b69c953498cf17bd70aaac7ab25525ed60 Cr-Commit-Position: refs/heads/master@{#33979}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M src/wasm/asm-wasm-builder.cc View 27 chunks +39 lines, -39 lines 0 comments Download
M src/wasm/ast-decoder.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
titzer
4 years, 10 months ago (2016-02-15 08:33:57 UTC) #1
ahaas
lgtm https://codereview.chromium.org/1699793002/diff/1/src/wasm/asm-wasm-builder.cc File src/wasm/asm-wasm-builder.cc (right): https://codereview.chromium.org/1699793002/diff/1/src/wasm/asm-wasm-builder.cc#newcode641 src/wasm/asm-wasm-builder.cc:641: DCHECK(VariableLocation::PARAMETER == Why don't you use DCHECK_EQ here?
4 years, 10 months ago (2016-02-15 08:39:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699793002/20001
4 years, 10 months ago (2016-02-15 08:41:54 UTC) #4
titzer
On 2016/02/15 08:39:37, ahaas wrote: > lgtm > > https://codereview.chromium.org/1699793002/diff/1/src/wasm/asm-wasm-builder.cc > File src/wasm/asm-wasm-builder.cc (right): > ...
4 years, 10 months ago (2016-02-15 08:42:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 09:05:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699793002/20001
4 years, 10 months ago (2016-02-15 09:06:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 09:07:56 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 09:08:56 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4bce03b69c953498cf17bd70aaac7ab25525ed60
Cr-Commit-Position: refs/heads/master@{#33979}

Powered by Google App Engine
This is Rietveld 408576698