Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issue 1699743002: Remove unused "Desktop bookmarks" folder name on Android. (Closed)

Created:
4 years, 10 months ago by newt (away)
Modified:
4 years, 10 months ago
Reviewers:
Ian Wen, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused "Desktop bookmarks" folder name on Android. There's no need anymore for complicated logic to choose between the name "Desktop bookmarks" and "Bookmarks bar"; we always use the latter option. BUG=474719 Committed: https://crrev.com/21f70bbc6b0f78241025b38407d2c3d5329f6627 Cr-Commit-Position: refs/heads/master@{#375755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/bookmark_bar_strings.grdp View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
newt (away)
PTAL
4 years, 10 months ago (2016-02-16 21:02:40 UTC) #2
Ian Wen
lgtm. We found out that the "boookmark bar" node is not sync'ed and its title ...
4 years, 10 months ago (2016-02-16 21:57:29 UTC) #3
sky
LGTM
4 years, 10 months ago (2016-02-17 00:38:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699743002/1
4 years, 10 months ago (2016-02-17 00:53:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 02:09:26 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 02:12:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21f70bbc6b0f78241025b38407d2c3d5329f6627
Cr-Commit-Position: refs/heads/master@{#375755}

Powered by Google App Engine
This is Rietveld 408576698