Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699673002: bluetooth: Require valid UUIDs when testing against Web Bluetooth Blacklist. (Closed)

Created:
4 years, 10 months ago by scheib
Modified:
4 years, 10 months ago
Reviewers:
ortuno
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-blacklist-integration-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Require valid UUIDs when testing against Web Bluetooth Blacklist. Adding extra paranoia to the Web Bluetooth blacklist by CHECK()ing that bluetooth UUIDs are valid when testing them against the blacklist. BUG=584398 Committed: https://crrev.com/4a230e0d60d9759817709442ba5351389e03fe8f Cr-Commit-Position: refs/heads/master@{#376902}

Patch Set 1 #

Total comments: 2

Patch Set 2 : added check when adding uuid. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M content/browser/bluetooth/bluetooth_blacklist.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/bluetooth/bluetooth_blacklist.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/bluetooth/bluetooth_blacklist_unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1666003002 Patch 170001

Messages

Total messages: 10 (3 generated)
scheib
4 years, 10 months ago (2016-02-14 01:27:24 UTC) #2
ortuno
https://codereview.chromium.org/1699673002/diff/1/content/browser/bluetooth/bluetooth_blacklist.cc File content/browser/bluetooth/bluetooth_blacklist.cc (right): https://codereview.chromium.org/1699673002/diff/1/content/browser/bluetooth/bluetooth_blacklist.cc#newcode55 content/browser/bluetooth/bluetooth_blacklist.cc:55: CHECK(uuid.IsValid()); Why not check that added UUIDs are valid ...
4 years, 10 months ago (2016-02-19 20:54:51 UTC) #3
scheib
Added check at Add as well. https://codereview.chromium.org/1699673002/diff/1/content/browser/bluetooth/bluetooth_blacklist.cc File content/browser/bluetooth/bluetooth_blacklist.cc (right): https://codereview.chromium.org/1699673002/diff/1/content/browser/bluetooth/bluetooth_blacklist.cc#newcode55 content/browser/bluetooth/bluetooth_blacklist.cc:55: CHECK(uuid.IsValid()); On 2016/02/19 ...
4 years, 10 months ago (2016-02-22 20:27:12 UTC) #4
ortuno
lgtm
4 years, 10 months ago (2016-02-22 22:49:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699673002/20001
4 years, 10 months ago (2016-02-22 22:58:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 02:06:51 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 02:09:27 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4a230e0d60d9759817709442ba5351389e03fe8f
Cr-Commit-Position: refs/heads/master@{#376902}

Powered by Google App Engine
This is Rietveld 408576698