Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: media/capture/service/video_capture_handler_impl_unittest.cc

Issue 1699553002: Mojo Video Capture service in media/capture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added missing BUILD deps Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/service/video_capture_handler_impl_unittest.cc
diff --git a/media/capture/service/video_capture_handler_impl_unittest.cc b/media/capture/service/video_capture_handler_impl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..170e2c8154611814fa82bd3819afcab3f8c65fa7
--- /dev/null
+++ b/media/capture/service/video_capture_handler_impl_unittest.cc
@@ -0,0 +1,229 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/run_loop.h"
+#include "media/base/media_switches.h"
+#include "media/capture/service/video_capture_handler_impl.h"
+#include "media/capture/video/fake_video_capture_device_factory.h"
+#include "mojo/converters/geometry/geometry_type_converters.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::_;
+using ::testing::InSequence;
+using ::testing::Field;
+
+namespace media {
+
+namespace {
+
+ACTION_P(RunClosure, closure) {
+ closure.Run();
+}
+
+} // anonymous namespace
+
+class VideoCaptureHandlerImplTest : public testing::Test {
+ public:
+ VideoCaptureHandlerImplTest() {}
+
+ void SetUp() override {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kUseFakeDeviceForMediaStream);
+ video_capture_handler_impl_.reset(
+ new VideoCaptureHandlerImpl(nullptr /* app */));
+ }
+
+ MOCK_METHOD1(DoOnRequestMediaDevicesReply,
+ void(const video_capture::MediaDevicesInfoReply&));
+ void OnRequestMediaDevicesReply(
+ video_capture::MediaDevicesInfoReplyPtr reply) {
+ DVLOG(1) << __FUNCTION__;
+ DoOnRequestMediaDevicesReply(*reply);
+ media_devices_info_ = std::move(reply);
+ }
+ MOCK_METHOD1(DoOnRequestStreamReply, void(const video_capture::Stream&));
+ void OnRequestStreamReply(video_capture::StreamPtr stream) {
+ DVLOG(1) << __FUNCTION__;
+ DoOnRequestStreamReply(*stream);
+ }
+
+ void RequestMediaDevices(
+ video_capture::MediaDevicesInfoRequestPtr request,
+ const VideoCaptureHandlerImpl::RequestMediaDevicesCallback& callback) {
+ video_capture_handler_impl_->RequestMediaDevices(std::move(request),
+ callback);
+ }
+
+ void SetNumFakeDevices(int num) {
+ static_cast<media::FakeVideoCaptureDeviceFactory*>(
+ video_capture_handler_impl_->video_capture_device_factory_.get())
+ ->set_number_of_devices(num);
+ }
+
+ void RequestStream(
+ video_capture::StreamOptionsPtr options,
+ const mojo::String& security_origin,
+ const VideoCaptureHandlerImpl::RequestStreamCallback& callback) {
+ video_capture_handler_impl_->RequestStream(std::move(options),
+ security_origin, callback);
+ }
+
+ protected:
+ // Needed for the mojo::ApplicationImpl inside VideoCaptureHandlerImpl.
+ const base::MessageLoop loop_;
+
+ // Need a SystemMonitor for VideoCaptureHandlerImpl to register to.
+ base::SystemMonitor system_monitor_;
+
+ // The class under test. Needs to be a scoped_ptr to be initialized after
+ // adding |kUseFakeDeviceForMediaStream| command line flag.
+ scoped_ptr<VideoCaptureHandlerImpl> video_capture_handler_impl_;
+
+ // Variable to hold on to the returned list of enumerated devices.
+ video_capture::MediaDevicesInfoReplyPtr media_devices_info_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(VideoCaptureHandlerImplTest);
+};
+
+TEST_F(VideoCaptureHandlerImplTest, CreateAndDestroy) {}
+
+// Tests a cycle RequestMediaDevices()-> RequestMediaDevicesCallback().
+TEST_F(VideoCaptureHandlerImplTest, RequestMediaDevices) {
+ InSequence s;
+ const int kRequestId = 123;
+
+ video_capture::MediaDevicesInfoRequestPtr request =
+ video_capture::MediaDevicesInfoRequest::New();
+ request->request_id = kRequestId;
+
+ VideoCaptureHandlerImpl::RequestMediaDevicesCallback callback =
+ base::Bind(&VideoCaptureHandlerImplTest::OnRequestMediaDevicesReply,
+ base::Unretained(this));
+
+ base::RunLoop run_loop;
+ base::Closure quit_closure = run_loop.QuitClosure();
+ EXPECT_CALL(*this, DoOnRequestMediaDevicesReply(Field(
+ &video_capture::MediaDevicesInfoReply::request_id,
+ kRequestId)))
+ .Times(1)
+ .WillOnce(RunClosure(quit_closure));
+ RequestMediaDevices(std::move(request), std::move(callback));
+
+ run_loop.Run();
+ ASSERT_EQ(1u, media_devices_info_->sources.size());
+ EXPECT_EQ(video_capture::SourceKind::Video,
+ media_devices_info_->sources[0]->kind);
+}
+
+// Tests a cycle RequestMediaDevices()-> RequestMediaDevicesCallback() before
+// and after a change in system devices has happened.
+TEST_F(VideoCaptureHandlerImplTest, RequestMediaDevicesAndReenumerate) {
+ InSequence s;
+ const int kRequestId = 123;
+
+ { // 1 Enumeration RequestMediaDevices()-> RequestMediaDevicesCallback().
+ video_capture::MediaDevicesInfoRequestPtr request =
+ video_capture::MediaDevicesInfoRequest::New();
+ request->request_id = kRequestId;
+
+ VideoCaptureHandlerImpl::RequestMediaDevicesCallback callback =
+ base::Bind(&VideoCaptureHandlerImplTest::OnRequestMediaDevicesReply,
+ base::Unretained(this));
+
+ base::RunLoop run_loop;
+ base::Closure quit_closure = run_loop.QuitClosure();
+ EXPECT_CALL(*this, DoOnRequestMediaDevicesReply(Field(
+ &video_capture::MediaDevicesInfoReply::request_id,
+ kRequestId)))
+ .Times(1)
+ .WillOnce(RunClosure(quit_closure));
+ RequestMediaDevices(std::move(request), std::move(callback));
+ run_loop.Run();
+
+ ASSERT_GE(media_devices_info_->sources.size(), 1u);
+ }
+
+ SetNumFakeDevices(2);
+ system_monitor_.ProcessDevicesChanged(
+ base::SystemMonitor::DEVTYPE_VIDEO_CAPTURE);
+ base::RunLoop().RunUntilIdle();
+
+ {
+ video_capture::MediaDevicesInfoRequestPtr request =
+ video_capture::MediaDevicesInfoRequest::New();
+ request->request_id = kRequestId;
+
+ VideoCaptureHandlerImpl::RequestMediaDevicesCallback callback =
+ base::Bind(&VideoCaptureHandlerImplTest::OnRequestMediaDevicesReply,
+ base::Unretained(this));
+
+ base::RunLoop run_loop;
+ base::Closure quit_closure = run_loop.QuitClosure();
+ EXPECT_CALL(*this, DoOnRequestMediaDevicesReply(Field(
+ &video_capture::MediaDevicesInfoReply::request_id,
+ kRequestId)))
+ .Times(1)
+ .WillOnce(RunClosure(quit_closure));
+ RequestMediaDevices(std::move(request), std::move(callback));
+ run_loop.Run();
+
+ ASSERT_GE(media_devices_info_->sources.size(), 2u);
+ }
+}
+
+// Tests a cycle RequestStream() -> RequestStreamCallback().
+TEST_F(VideoCaptureHandlerImplTest, RequestStream) {
+ InSequence s;
+
+ { // Enumerate devices to get a valid |id| for the first one.
+ const int kRequestId = 123;
+ video_capture::MediaDevicesInfoRequestPtr request =
+ video_capture::MediaDevicesInfoRequest::New();
+ request->request_id = kRequestId;
+
+ VideoCaptureHandlerImpl::RequestMediaDevicesCallback callback =
+ base::Bind(&VideoCaptureHandlerImplTest::OnRequestMediaDevicesReply,
+ base::Unretained(this));
+
+ base::RunLoop run_loop;
+ base::Closure quit_closure = run_loop.QuitClosure();
+ EXPECT_CALL(*this, DoOnRequestMediaDevicesReply(Field(
+ &video_capture::MediaDevicesInfoReply::request_id,
+ kRequestId)))
+ .Times(1)
+ .WillOnce(RunClosure(quit_closure));
+ RequestMediaDevices(std::move(request), std::move(callback));
+
+ run_loop.Run();
+ }
+ {
+ const int kRequestId = 456;
+ video_capture::StreamOptionsPtr options =
+ video_capture::StreamOptions::New();
+ options->request_id = kRequestId;
+ options->device_id = media_devices_info_->sources[0]->device_id;
+ options->capture_size = mojo::Size::From(gfx::Size(640, 480));
+ options->frame_rate = 30.0;
+
+ VideoCaptureHandlerImpl::RequestStreamCallback callback =
+ base::Bind(&VideoCaptureHandlerImplTest::OnRequestStreamReply,
+ base::Unretained(this));
+
+ base::RunLoop run_loop;
+ base::Closure quit_closure = run_loop.QuitClosure();
+
+ // TODO(mcasas): Inspect the replied sources[0] contents.
+ EXPECT_CALL(*this, DoOnRequestStreamReply(_))
+ .Times(1)
+ .WillOnce(RunClosure(quit_closure));
+ RequestStream(std::move(options), "https://localhost", std::move(callback));
+
+ run_loop.Run();
+ }
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698