Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1699473002: Try fixing unused-variable warnings another way. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Try fixing unused-variable warnings another way. If we mark these as extern, the compiler won't complain they're unused. This is an unsatisfying hack, but last time we tried to condition these on non-NEON only, Chromium's GN linux ARM bot failed. They must not be configured to use the NEON procs? BUG=skia:4798 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699473002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/fed90d4712422e5f417169083c59ca749daeae72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/opts/SkBlitRow_opts_arm.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mtklein_C
4 years, 10 months ago (2016-02-12 21:32:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699473002/1
4 years, 10 months ago (2016-02-12 21:32:26 UTC) #5
msarett
lgtm
4 years, 10 months ago (2016-02-12 21:33:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699473002/1
4 years, 10 months ago (2016-02-12 21:35:57 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 21:56:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fed90d4712422e5f417169083c59ca749daeae72

Powered by Google App Engine
This is Rietveld 408576698