Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169943002: rebaseline_server: fail fast if skpdiff binary is not available (Closed)

Created:
6 years, 10 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: fail fast if skpdiff binary is not available NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13484

Patch Set 1 #

Patch Set 2 : retry after "error: old chunk mismatch" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M gm/rebaseline_server/imagediffdb.py View 5 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ravi, PTAL. (And note that the file diffs from my first "git cl upload" fail ...
6 years, 10 months ago (2014-02-17 20:44:55 UTC) #1
rmistry
LGTM
6 years, 10 months ago (2014-02-17 21:00:28 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 10 months ago (2014-02-18 14:38:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/169943002/40001
6 years, 10 months ago (2014-02-18 14:38:18 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 14:38:24 UTC) #5
Message was sent while issue was closed. 
Change committed as 13484

Powered by Google App Engine
This is Rietveld 408576698