[Android] Change the AutofillPopup UI.

[Android] Change the AutofillPopup UI.

Change the AutofillPopup to use two row design instead of one row.
Also removing the padding from the popup so that it would adjust better
with the edges of the input field.

Screenshots: http://goo.gl/YyyTs

BUG=176386, 251701
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208526

[aurimas (slooooooooow), 2013-06-13 22:04:26]

Hey Ted,

Please take a look at this CL.

Thanks!
Aurimas

[Ilya Sherman, 2013-06-13 22:31:12]

I'm a little worried about not being able to show enough two-line suggestions
with so little screen real estate.  Could you post some screenshots in landscape
orientation, and with the initiating field being roughly in the middle of the
visible screen space?

Also, unrelated to this CL: Does Android not show entries in the popup for
managing Autofill settings or clearing the form?  Does the popup support
scrolling for overflow?

[aurimas (slooooooooow), 2013-06-13 22:40:42]

On 2013/06/13 22:31:12, Ilya Sherman wrote:
> I'm a little worried about not being able to show enough two-line suggestions
> with so little screen real estate.  Could you post some screenshots in
landscape
> orientation, and with the initiating field being roughly in the middle of the
> visible screen space?
Added the screenshots to the link in the description. You are right, there is
little space, but even before Autofill popups were not really useful.

> 
> Also, unrelated to this CL: Does Android not show entries in the popup for
> managing Autofill settings or clearing the form? 
We never showed settings or clear form due to the lack of space.

>Does the popup support scrolling for overflow?
Yes, these popups are scrollable.

[Ilya Sherman, 2013-06-13 22:50:27]

On 2013/06/13 22:40:42, aurimas wrote:
> On 2013/06/13 22:31:12, Ilya Sherman wrote:
> > I'm a little worried about not being able to show enough two-line
suggestions
> > with so little screen real estate.  Could you post some screenshots in
> landscape
> > orientation, and with the initiating field being roughly in the middle of
the
> > visible screen space?
> Added the screenshots to the link in the description. You are right, there is
> little space, but even before Autofill popups were not really useful.

Thanks.  Could you also post a screenshot for portrait mode where the initiating
field is roughly in the middle of the space between the omnibox and the
keyboard?  I think that's the worst case scenario, space-wise -- just want to
see what that looks like.

> > Also, unrelated to this CL: Does Android not show entries in the popup for
> > managing Autofill settings or clearing the form? 
> We never showed settings or clear form due to the lack of space.
> 
> >Does the popup support scrolling for overflow?
> Yes, these popups are scrollable.

Okay, good to know.  Thanks :)

[aurimas (slooooooooow), 2013-06-14 01:01:52]

> Thanks.  Could you also post a screenshot for portrait mode where the
initiating
> field is roughly in the middle of the space between the omnibox and the
> keyboard?  I think that's the worst case scenario, space-wise -- just want to
> see what that looks like.

I added these screenshots

[Ted C, 2013-06-14 20:57:52]

lgtm code wise w/ comments

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/res/l...
File chrome/android/java/res/layout/autofill_text.xml (right):

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/res/l...
chrome/android/java/res/layout/autofill_text.xml:30:
android:includeFontPadding="false"
Why add this out of curiosity?

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:184:
float labelWidth = 0;
this isn't used until after the conditional

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:192:
float sublabelWidth = 0;
same here

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:193:
if (sublabel.length() > 0) {
TextUtils isEmpty?

[aurimas (slooooooooow), 2013-06-14 21:09:08]

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/res/l...
File chrome/android/java/res/layout/autofill_text.xml (right):

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/res/l...
chrome/android/java/res/layout/autofill_text.xml:30:
android:includeFontPadding="false"
On 2013/06/14 20:57:53, Ted C wrote:
> Why add this out of curiosity?

This seems to reduce the padding between label and sublabel without using
negative margin values.

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:184:
float labelWidth = 0;
On 2013/06/14 20:57:53, Ted C wrote:
> this isn't used until after the conditional

Done.

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:192:
float sublabelWidth = 0;
On 2013/06/14 20:57:53, Ted C wrote:
> same here

Done.

https://codereview.chromium.org/16994006/diff/21001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:193:
if (sublabel.length() > 0) {
On 2013/06/14 20:57:53, Ted C wrote:
> TextUtils isEmpty?

Done.

[commit-bot: I haz the power, 2013-06-25 14:31:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/16994006/38001

[commit-bot: I haz the power, 2013-06-25 14:32:01]

Can't process patch for file
chrome/android/java/res/drawable/autofill_popup_background_up.9.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[commit-bot: I haz the power, 2013-06-25 16:23:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/16994006/54001

[commit-bot: I haz the power, 2013-06-25 18:21:26]

Change committed as 208526