Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1699353002: Fix pkgconfig file re-naming in sysroot-creator.sh (Closed)

Created:
4 years, 10 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@update_sysroot
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pkgconfig file re-naming in sysroot-creator.sh Since we added udev to the sysroot /usr/lib/pkgconfig now already exists (previously only /usr/lib/<arch>/pkgconfig existed) so simply using 'mv' to rename the directory is no longer enough. BUG=561584 Committed: https://crrev.com/5c9493141fbc4afb6de44f31964adb01e4bfa4c0 Cr-Commit-Position: refs/heads/master@{#376030}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M build/linux/sysroot_scripts/sysroot-creator.sh View 1 2 3 5 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sam Clegg
4 years, 10 months ago (2016-02-17 22:34:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699353002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699353002/60001
4 years, 10 months ago (2016-02-17 22:39:20 UTC) #6
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-17 22:59:21 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 23:15:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699353002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699353002/60001
4 years, 10 months ago (2016-02-17 23:22:05 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-17 23:30:50 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 23:31:53 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5c9493141fbc4afb6de44f31964adb01e4bfa4c0
Cr-Commit-Position: refs/heads/master@{#376030}

Powered by Google App Engine
This is Rietveld 408576698