Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: public/platform/WebExternalTextureMailbox.h

Issue 169933002: WebGL: Don't destroy mailbox textures in the destructor until they're released. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Define operator!= also Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/graphics/gpu/DrawingBufferTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 signed char name[64]; 37 signed char name[64];
38 unsigned syncPoint; 38 unsigned syncPoint;
39 39
40 WebExternalTextureMailbox() 40 WebExternalTextureMailbox()
41 : syncPoint(0) 41 : syncPoint(0)
42 { 42 {
43 memset(name, 0, sizeof(name)); 43 memset(name, 0, sizeof(name));
44 } 44 }
45 }; 45 };
46 46
47 inline bool operator==(const WebExternalTextureMailbox& a, const WebExternalText ureMailbox& b)
48 {
49 return !memcmp(a.name, b.name, sizeof(a.name));
abarth-chromium 2014/04/24 14:59:06 We don't need to compare the syncPoint as well?
dshwang 2014/04/24 15:03:23 we don't need syncPoint comparison. The main purpo
danakj 2014/04/24 15:10:02 If you're not comparing every field, might I sugge
dshwang 2014/04/24 15:19:11 nameEquals() looks better. It's why I wait while d
50 }
51
52 inline bool operator!=(const WebExternalTextureMailbox& a, const WebExternalText ureMailbox& b)
53 {
54 return !(a == b);
55 }
56
47 } // namespace blink 57 } // namespace blink
48 58
49 #endif // WebExternalTextureMailbox_h 59 #endif // WebExternalTextureMailbox_h
OLDNEW
« no previous file with comments | « Source/platform/graphics/gpu/DrawingBufferTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698