Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1699293002:
add back Sk4i (Closed)
Descriptionadd back Sk4i
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699293002
Committed: https://skia.googlesource.com/skia/+/ff9febf82f5c9329c2899287c771348dba9e83ae
Patch Set 1 #
Messages
Total messages: 15 (6 generated)
Description was changed from ========== add it back Sk4i BUG=skia: ========== to ========== add it back Sk4i BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
mtklein@chromium.org changed reviewers: + herb@google.com
The CQ bit was checked by mtklein@chromium.org
Gonna start slowly putting back pieces of that reverted CL from last week.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699293002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-02-17 03:45 UTC
Description was changed from ========== add it back Sk4i BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== add back Sk4i BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
lgtm
Message was sent while issue was closed.
Description was changed from ========== add back Sk4i BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== add back Sk4i BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/ff9febf82f5c9329c2899287c771348dba9e83ae ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ff9febf82f5c9329c2899287c771348dba9e83ae
Message was sent while issue was closed.
reed@google.com changed reviewers: + reed@google.com
Message was sent while issue was closed.
woot! I'm working on LCD text blits w/ Sk4f, and I needed to construct Sk4f from 4 separate int-calculations.. I did a cast form Sk4h, but Sk4i seems better, since it will skip a step, yes? Sk4f scale = SkNx_cast<float>(Sk4i(a, b, c, d));
Message was sent while issue was closed.
On 2016/02/17 14:25:18, reed1 wrote: > woot! > > I'm working on LCD text blits w/ Sk4f, and I needed to construct Sk4f from 4 > separate int-calculations.. I did a cast form Sk4h, but Sk4i seems better, since > it will skip a step, yes? > > Sk4f scale = SkNx_cast<float>(Sk4i(a, b, c, d)); Uh, it _can_ skip a step. The code to make it skip the step was part of that CL I reverted Friday. You shouldn't see much difference between Sk4f scale(a,b,c,d) and Sk4f scale(Sk4i(a,b,c,d)) until I get that re-landed.
Message was sent while issue was closed.
My thought was to only pay for 1 int-to-float conversion step, which I presumed would happen in-bulk if I built a 4i or 4h first...
Message was sent while issue was closed.
On 2016/02/17 14:31:59, reed1 wrote: > My thought was to only pay for 1 int-to-float conversion step, which I presumed > would happen in-bulk if I built a 4i or 4h first... Yes exactly. That part was reverted Friday. Today you'll see 4 scalar conversions. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
