Serialize and resynthesize unresolved constant instance creations.

Serialize and resynthesize unresolved constant instance creations.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/511639d6eaf19798ae781ace1e35234fb5ff046e

[Paul Berry, 2016-02-16 20:44:10]

lgtm assuming additional test cases are added.

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:534: } else if (info.element ==
null) {
Remove this case (it's unreachable since we already check `info.element != null`
on line 529)

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:1479: 
Let's also add tests for cases involving prefixes, e.g.:

import 'a.dart' as p;
const V = const p.C.named();

(Test both the case where p.C exists but p.C.named() does not, as well as the
case where p.C does not exist)

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:1524: 
Similarly, also test the case:

import 'a.dart' as p;
const V = const p.C();

where p.C does not exist.

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1972:
test_constExpr_invokeConstructor_unresolved_named() {
Also make a version of this test where class C is undefined.

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1994:
test_constExpr_invokeConstructor_unresolved_named_prefixed() {
Also make a version of this test where class C is undefined.

[scheglov, 2016-02-16 21:48:44]

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:534: } else if (info.element ==
null) {
On 2016/02/16 20:44:10, Paul Berry wrote:
> Remove this case (it's unreachable since we already check `info.element !=
null`
> on line 529)

Done.

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:1479: 
On 2016/02/16 20:44:10, Paul Berry wrote:
> Let's also add tests for cases involving prefixes, e.g.:
> 
> import 'a.dart' as p;
> const V = const p.C.named();
> 
> (Test both the case where p.C exists but p.C.named() does not, as well as the
> case where p.C does not exist)

Done.

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:1524: 
On 2016/02/16 20:44:10, Paul Berry wrote:
> Similarly, also test the case:
> 
> import 'a.dart' as p;
> const V = const p.C();
> 
> where p.C does not exist.

Done.

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1972:
test_constExpr_invokeConstructor_unresolved_named() {
On 2016/02/16 20:44:10, Paul Berry wrote:
> Also make a version of this test where class C is undefined.

Done.

https://codereview.chromium.org/1699243003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1994:
test_constExpr_invokeConstructor_unresolved_named_prefixed() {
On 2016/02/16 20:44:10, Paul Berry wrote:
> Also make a version of this test where class C is undefined.

Done.

[scheglov, 2016-02-16 21:49:13]

Description was changed from

==========
Serialize and resynthesize unresolved constant instance creations.

R=paulberry@google.com
BUG=
==========

to

==========
Serialize and resynthesize unresolved constant instance creations.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/511639d6eaf19798ae781ace1e35234fb5ff046e
==========

[scheglov, 2016-02-16 21:49:14]

Committed patchset #2 (id:20001) manually as
511639d6eaf19798ae781ace1e35234fb5ff046e (presubmit successful).