Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3820)

Unified Diff: chrome/browser/media_galleries/media_galleries_preferences.cc

Issue 1699223002: Media Galleries Maintainence: Eliminate some todos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media_galleries/media_galleries_preferences.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_galleries/media_galleries_preferences.cc
diff --git a/chrome/browser/media_galleries/media_galleries_preferences.cc b/chrome/browser/media_galleries/media_galleries_preferences.cc
index 2c14b1f8e73ac0175fb267b611ea71c83cfac838..13679e77a4a2acf59b309e74fea14fa7da3d46a1 100644
--- a/chrome/browser/media_galleries/media_galleries_preferences.cc
+++ b/chrome/browser/media_galleries/media_galleries_preferences.cc
@@ -835,6 +835,9 @@ base::FilePath MediaGalleriesPreferences::LookUpGalleryPathForExtension(
known_galleries_.find(gallery_id);
if (it == known_galleries_.end())
return base::FilePath();
+
+ // This seems wrong: it just returns the absolute path to the device, which
+ // is not necessarily the gallery path.
return MediaStorageUtil::FindDevicePathById(it->second.device_id);
}
« no previous file with comments | « chrome/browser/media_galleries/media_galleries_preferences.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698