Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 1699223002: Media Galleries Maintainence: Eliminate some todos (Closed)

Created:
4 years, 10 months ago by tommycli
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang, chromium-apps-reviews_chromium.org, tommycli, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Galleries Maintainence: Eliminate some todos 1. Removes some obsolete CHECKs. 2. Removes an obsolete TODO (while preserving a comment). BUG=NONE Committed: https://crrev.com/1a4c40817b709fb404938aec19fde128f557b55c Cr-Commit-Position: refs/heads/master@{#375663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tommycli
thestig: PTAL misc todo elimination
4 years, 10 months ago (2016-02-16 19:44:22 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-16 19:49:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699223002/1
4 years, 10 months ago (2016-02-16 19:57:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/125806)
4 years, 10 months ago (2016-02-16 20:21:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699223002/1
4 years, 10 months ago (2016-02-16 20:57:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 21:17:13 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:54:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a4c40817b709fb404938aec19fde128f557b55c
Cr-Commit-Position: refs/heads/master@{#375663}

Powered by Google App Engine
This is Rietveld 408576698