Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1699213003: [spellcheck] Reorder spellcheck options in context menu. (Closed)

Created:
4 years, 10 months ago by please use gerrit instead
Modified:
4 years, 10 months ago
Reviewers:
groby-ooo-7-16, lazyboy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@spell-menu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[spellcheck] Reorder spellcheck options in context menu. Mac: - Put "Language settings" on top of "Writing direction". Win/CrOS/Lin: - Put "Spellcheck" on top of "Writing direction". - Group "Language settings" together with spellcheck languages, before the horizontal separator. This is done at UX request. BUG=544234 Committed: https://crrev.com/5def0de596a472b50c5bfb99ec218c36241e4631 Cr-Commit-Position: refs/heads/master@{#376207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
please use gerrit instead
Rachel, ptal.
4 years, 10 months ago (2016-02-17 02:17:07 UTC) #2
groby-ooo-7-16
Quite lovely. LGTM
4 years, 10 months ago (2016-02-18 03:03:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699213003/1
4 years, 10 months ago (2016-02-18 16:58:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/147406)
4 years, 10 months ago (2016-02-18 17:13:42 UTC) #7
please use gerrit instead
lazyboy@: owner ptal.
4 years, 10 months ago (2016-02-18 17:20:51 UTC) #9
lazyboy
Rubber stamp lgtm.
4 years, 10 months ago (2016-02-18 18:08:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699213003/1
4 years, 10 months ago (2016-02-18 18:14:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 18:27:00 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 18:28:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5def0de596a472b50c5bfb99ec218c36241e4631
Cr-Commit-Position: refs/heads/master@{#376207}

Powered by Google App Engine
This is Rietveld 408576698