Add layout support for the snap-height property

Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support was added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Unit and baseline for line boxes are supported, but block-level
replaced elements is not supported in this patch yet.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDKCwAJ

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html

Committed: https://crrev.com/3497d2109613cf498736cea8e1330c0ac8c89a4d
Cr-Commit-Position: refs/heads/master@{#376338}

[kojii, 2016-02-18 03:55:35]

Description was changed from

==========
WIP: snap-height-layout

BUG=
==========

to

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support is added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

[kojii, 2016-02-18 04:15:20]

Description was changed from

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support is added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

to

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support is added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

[kojii, 2016-02-18 04:15:36]

Description was changed from

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support is added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

to

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support is added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

[kojii, 2016-02-18 04:18:59]

Description was changed from

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support is added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

to

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support was added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

[kojii, 2016-02-18 05:08:24]

Description was changed from

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support was added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

to

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support was added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Unit and baseline for line boxes are supported, but block-level
replaced elements is not supported in this patch yet.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

[kojii, 2016-02-18 06:50:59]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-02-18 06:51:00]

PTAL.

[eae, 2016-02-18 18:02:12]

https://codereview.chromium.org/1699213002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp (right):

https://codereview.chromium.org/1699213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp:246:
snapHeight(maxAscent, maxDescent, lineLayoutItem().styleRef());
if (lineLayoutItem().styleRef().snapHeightUnit())
  snapHeight(...)

[kojii, 2016-02-18 19:43:59]

Patchset #3 (id:40001) has been deleted

[kojii, 2016-02-18 20:30:32]

PTAL.

https://codereview.chromium.org/1699213002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp (right):

https://codereview.chromium.org/1699213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp:246:
snapHeight(maxAscent, maxDescent, lineLayoutItem().styleRef());
On 2016/02/18 at 18:02:12, eae wrote:
> if (lineLayoutItem().styleRef().snapHeightUnit())
>   snapHeight(...)

Done, thank you.

[eae, 2016-02-18 23:26:32]

Thanks!

LGTM!

[kojii, 2016-02-19 00:10:11]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-02-19 00:19:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699213002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699213002/60001

[commit-bot: I haz the power, 2016-02-19 01:39:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-02-19 01:40:48]

Description was changed from

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support was added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Unit and baseline for line boxes are supported, but block-level
replaced elements is not supported in this patch yet.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html
==========

to

==========
Add layout support for the snap-height property

This patch adds layout support for the snap-height property, which is
behind the CSSSnapSize runtime flag. CSS Parser support was added in
crrev.com/376051.

Two ref tests were upstreamed to csswg-test/css-snap-size-1 and
imported. This patch passes these tests.

Unit and baseline for line boxes are supported, but block-level
replaced elements is not supported in this patch yet.

Spec: https://drafts.csswg.org/css-snap-size/#snap-height
Dashboard: https://www.chromestatus.com/features/5734273533345792
Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_-RlGYnb5W8/bfFbSGDK...

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-*.html

Committed: https://crrev.com/3497d2109613cf498736cea8e1330c0ac8c89a4d
Cr-Commit-Position: refs/heads/master@{#376338}
==========

[commit-bot: I haz the power, 2016-02-19 01:40:49]

Patchset 3 (id:??) landed as
https://crrev.com/3497d2109613cf498736cea8e1330c0ac8c89a4d
Cr-Commit-Position: refs/heads/master@{#376338}