Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 1699183003: [DevTools] Don't load sourcemap for blackboxed scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3
Patch Set: Rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
index be2e646b1b1acb494cc7ec1a53e923a5fceb2fa8..5504a04a7dbf22120745dd69365f7718ee78a03f 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
@@ -49,7 +49,7 @@ WebInspector.BlackboxManager.prototype = {
isBlackboxedRawLocation: function(location)
{
if (!this._scriptIdToPositions.has(location.scriptId))
- return false;
+ return this._isBlackboxedScript(location.script());
var positions = this._scriptIdToPositions.get(location.scriptId);
var index = positions.lowerBound(location, comparator);
return !!(index % 2);
@@ -312,6 +312,9 @@ WebInspector.BlackboxManager.prototype = {
if (success) {
this._scriptIdToPositions.set(script.scriptId, positions);
this._debuggerWorkspaceBinding.updateLocations(script);
+ var isBlackboxed = positions.length !== 0;
+ if (!isBlackboxed && script.sourceMapURL)
+ this._debuggerWorkspaceBinding.loadSourceMap(script);
} else if (!this._scriptIdToPositions.has(script.scriptId))
this._scriptIdToPositions.set(script.scriptId, []);
}

Powered by Google App Engine
This is Rietveld 408576698