More SecurityContext calls accept a password.

More SecurityContext calls accept a password.

Any PKCS12 container, not just those containing a private key, can be
protected by a password. This change adds an optional named `password`
parameter to other SecurityContext calls, and plumbs it through to
the calls reading PKCS12 data.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/38786e95661df675ccc4aad28e8a5d8bb6515246

[zra, 2016-02-16 17:29:18]

Description was changed from

==========
More SecurityContext calls accept a password.

Any PKCS12 container, not just those containing a private key, can be
protected by a password. This change adds an optional named `password`
parameter to other SecurityContext calls, and plums it through to
the calls reading PKCS12 data.
==========

to

==========
More SecurityContext calls accept a password.

Any PKCS12 container, not just those containing a private key, can be
protected by a password. This change adds an optional named `password`
parameter to other SecurityContext calls, and plumbs it through to
the calls reading PKCS12 data.
==========

[zra, 2016-02-16 17:29:37]

zra@google.com changed reviewers:
+ iposva@google.com, whesse@google.com

[Bill Hesse, 2016-02-16 20:33:05]

lgtm

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
File tests/standalone/io/secure_server_client_certificate_test.dart (right):

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
tests/standalone/io/secure_server_client_certificate_test.dart:98: required:
true, sendCert: false, certType: 'p12', password: '');
Should you test PK12 files with a real password?

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
File tests/standalone/io/security_context_argument_test.dart (right):

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
tests/standalone/io/security_context_argument_test.dart:42: Expect.throws(() =>
c.useCertificateChainBytes(
We could do more tests - Null, and a really long string.

[zra, 2016-02-17 18:42:44]

Thanks!

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
File tests/standalone/io/secure_server_client_certificate_test.dart (right):

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
tests/standalone/io/secure_server_client_certificate_test.dart:98: required:
true, sendCert: false, certType: 'p12', password: '');
On 2016/02/16 20:33:05, Bill Hesse wrote:
> Should you test PK12 files with a real password?

Done.

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
File tests/standalone/io/security_context_argument_test.dart (right):

https://codereview.chromium.org/1699163002/diff/40001/tests/standalone/io/sec...
tests/standalone/io/security_context_argument_test.dart:42: Expect.throws(() =>
c.useCertificateChainBytes(
On 2016/02/16 20:33:05, Bill Hesse wrote:
> We could do more tests - Null, and a really long string.

Done.

[Bill Hesse, 2016-02-17 18:48:46]

LGTM.

https://codereview.chromium.org/1699163002/diff/80001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1699163002/diff/80001/CHANGELOG.md#newcode20
CHANGELOG.md:20: * All calls in `SecuirtyContext` that accept certificate data
now accept an
Typo SecuirtyContext.

[zra, 2016-02-17 18:58:22]

Description was changed from

==========
More SecurityContext calls accept a password.

Any PKCS12 container, not just those containing a private key, can be
protected by a password. This change adds an optional named `password`
parameter to other SecurityContext calls, and plumbs it through to
the calls reading PKCS12 data.
==========

to

==========
More SecurityContext calls accept a password.

Any PKCS12 container, not just those containing a private key, can be
protected by a password. This change adds an optional named `password`
parameter to other SecurityContext calls, and plumbs it through to
the calls reading PKCS12 data.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/38786e95661df675ccc4aad28e8a5d8bb6515246
==========

[zra, 2016-02-17 18:58:23]

Committed patchset #6 (id:100001) manually as
38786e95661df675ccc4aad28e8a5d8bb6515246 (presubmit successful).

[zra, 2016-02-17 18:58:54]

https://codereview.chromium.org/1699163002/diff/80001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1699163002/diff/80001/CHANGELOG.md#newcode20
CHANGELOG.md:20: * All calls in `SecuirtyContext` that accept certificate data
now accept an
On 2016/02/17 18:48:46, Bill Hesse wrote:
> Typo SecuirtyContext.

Done.