Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: runtime/vm/service.cc

Issue 1699153002: Add step OverAwait to service protocol (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index c8912eb48c240e41cc2a646e40a21cbc6536d69c..86a72d5debe2e0c1e069726d63f702407bfbf167 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2629,7 +2629,7 @@ static bool AddBreakpointAtActivation(Thread* thread, JSONStream* js) {
}
const Instance& closure = Instance::Cast(obj);
Breakpoint* bpt =
- thread->isolate()->debugger()->SetBreakpointAtActivation(closure);
+ thread->isolate()->debugger()->SetBreakpointAtActivation(closure, false);
if (bpt == NULL) {
js->PrintError(kCannotAddBreakpoint,
"%s: Cannot add breakpoint at activation",
@@ -3020,6 +3020,12 @@ static bool Resume(Thread* thread, JSONStream* js) {
isolate->debugger()->SetStepOver();
} else if (strcmp(step_param, "Out") == 0) {
isolate->debugger()->SetStepOut();
+ } else if (strcmp(step_param, "OverAsyncSuspension") == 0) {
+ if (!isolate->debugger()->SetupStepOverAsyncSuspension()) {
+ js->PrintError(kInvalidParams,
+ "Isolate must be paused at an async suspension point");
+ return true;
+ }
} else {
PrintInvalidParamError(js, "step");
return true;
@@ -3605,7 +3611,7 @@ static bool GetVersion(Thread* thread, JSONStream* js) {
JSONObject jsobj(js);
jsobj.AddProperty("type", "Version");
jsobj.AddProperty("major", static_cast<intptr_t>(3));
- jsobj.AddProperty("minor", static_cast<intptr_t>(2));
+ jsobj.AddProperty("minor", static_cast<intptr_t>(3));
jsobj.AddProperty("_privateMajor", static_cast<intptr_t>(0));
jsobj.AddProperty("_privateMinor", static_cast<intptr_t>(0));
return true;
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698