Add step OverAwait to service protocol

Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAsyncContinuation" boolean value.
- Resume command can take an 'OverAsyncContinuation' step mode.
- Breakpoints have an optional 'isSyntheticAsyncContinuation' boolean value.

Added low level step_over_await_test.

Issuing the OverAsyncContinuation resume command does the following:

- Adds a synthetic breakpoint (#1) to the async closure.
- Resumes the isolate.
- When we hit #1, the VM issues a StepOver and then reports us paused at #1.

At the next resume command, the VM will remove #1.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/5c8d79c55a69c6a80072a8eb8307e7e38085357b

[Cutch, 2016-02-16 16:31:19]

Description was changed from

==========
Add step OverAwait to service protocol
==========

to

==========
Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAwait" boolean value.
- Resume command can take an 'OverAwait' step mode.

Added low level step_over_await_test.

Issuing the OverAwait resume command does the following:

- Adds a synthetic breakpoint to the async closure.
- When this breakpoint is hit, the VM removes it and issues a StepOver without
notifying the client.
==========

[Cutch, 2016-02-16 16:31:19]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-16 16:35:13]

Description was changed from

==========
Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAwait" boolean value.
- Resume command can take an 'OverAwait' step mode.

Added low level step_over_await_test.

Issuing the OverAwait resume command does the following:

- Adds a synthetic breakpoint to the async closure.
- When this breakpoint is hit, the VM removes it and issues a StepOver without
notifying the client.
==========

to

==========
Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAwait" boolean value.
- Resume command can take an 'OverAwait' step mode.
- Breakpoints have an optional isSyntheticAsyncBreakpoint boolean value.

Added low level step_over_await_test.

Issuing the OverAwait resume command does the following:

- Adds a synthetic breakpoint to the async closure.
- When this breakpoint is hit, the VM removes it and issues a StepOver without
notifying the client.
==========

[rmacnak, 2016-02-16 21:21:59]

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
File runtime/observatory/lib/src/service/object.dart (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:1599: final Completer
breakpointRemoved = new Completer();
It would make more sense for the tests to wait for a pause event with the
synthetic breakpoint, not a breakpoint removed event. The breakpoint can
be removed without being hit.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:1915: @observable bool
atAsyncJump;
Don't need atAsyncJump anymore.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
File runtime/observatory/tests/service/step_over_await_test.dart (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/tests/service/step_over_await_test.dart:35: if (event.kind
== ServiceEvent.kBreakpointAdded) {
over-idented

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/tests/service/step_over_await_test.dart:60: if (event.kind
== ServiceEvent.kBreakpointRemoved) {
over-idented

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/tests/service/step_over_await_test.dart:82:
expect(isolate.pauseEvent.atAwait, isTrue);
Something's not right. There're at least two constructor calls to step over
between the debugger call and the await.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/debug...
File runtime/vm/debugger.cc (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/debug...
runtime/vm/debugger.cc:2810: bpt_hit = NULL;
It would clearer from the client's perspective if this id was part of the pause
event after the step over of the state machine.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/servi...
File runtime/vm/service_event.cc (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/servi...
runtime/vm/service_event.cc:227: jsobj.AddProperty("_atAsyncJump",
at_async_jump());
Don't need _atAsyncJump then.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/servi...
runtime/vm/service_event.cc:228: jsobj.AddProperty("atAwait", at_async_jump());
It's await or yield or yield*.

[Cutch, 2016-02-17 18:24:21]

PTAL

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
File runtime/observatory/lib/src/service/object.dart (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:1599: final Completer
breakpointRemoved = new Completer();
On 2016/02/16 21:21:58, rmacnak wrote:
> It would make more sense for the tests to wait for a pause event with the
> synthetic breakpoint, not a breakpoint removed event. The breakpoint can
> be removed without being hit.

Event sequence is now:

- kBreapointAdded (#1).
- kResume
- kPause (at #1).

And after the isolate is resumed (in any mode)

- kBreakpointRemoved (#1).

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:1915: @observable bool
atAsyncJump;
On 2016/02/16 21:21:58, rmacnak wrote:
> Don't need atAsyncJump anymore.

Removed this and asyncContinuation.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
File runtime/observatory/tests/service/step_over_await_test.dart (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/tests/service/step_over_await_test.dart:35: if (event.kind
== ServiceEvent.kBreakpointAdded) {
On 2016/02/16 21:21:58, rmacnak wrote:
> over-idented

Done.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/observat...
runtime/observatory/tests/service/step_over_await_test.dart:60: if (event.kind
== ServiceEvent.kBreakpointRemoved) {
On 2016/02/16 21:21:58, rmacnak wrote:
> over-idented

Done.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/debug...
File runtime/vm/debugger.cc (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/debug...
runtime/vm/debugger.cc:2810: bpt_hit = NULL;
On 2016/02/16 21:21:58, rmacnak wrote:
> It would clearer from the client's perspective if this id was part of the
pause
> event after the step over of the state machine.

Done.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/servi...
File runtime/vm/service_event.cc (right):

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/servi...
runtime/vm/service_event.cc:227: jsobj.AddProperty("_atAsyncJump",
at_async_jump());
On 2016/02/16 21:21:59, rmacnak wrote:
> Don't need _atAsyncJump then.

Done.

https://chromiumcodereview.appspot.com/1699153002/diff/40001/runtime/vm/servi...
runtime/vm/service_event.cc:228: jsobj.AddProperty("atAwait", at_async_jump());
On 2016/02/16 21:21:59, rmacnak wrote:
> It's await or yield or yield*.

bit on pause event:
atAsyncContinuation

bit on breakpoint:
isSyntheticAsyncContinuation

step command:
OverAsyncContinuation

[Cutch, 2016-02-17 18:36:49]

Description was changed from

==========
Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAwait" boolean value.
- Resume command can take an 'OverAwait' step mode.
- Breakpoints have an optional isSyntheticAsyncBreakpoint boolean value.

Added low level step_over_await_test.

Issuing the OverAwait resume command does the following:

- Adds a synthetic breakpoint to the async closure.
- When this breakpoint is hit, the VM removes it and issues a StepOver without
notifying the client.
==========

to

==========
Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAsyncContinuation" boolean value.
- Resume command can take an 'OverAsyncContinuation' step mode.
- Breakpoints have an optional 'isSyntheticAsyncContinuation' boolean value.

Added low level step_over_await_test.

Issuing the OverAsyncContinuation resume command does the following:

- Adds a synthetic breakpoint (#1) to the async closure.
- Resumes the isolate.
- When we hit #1, the VM issues a StepOver and then reports us paused at #1.

At the next resume command, the VM will remove #1.
==========

[rmacnak, 2016-02-17 18:52:00]

lgtm w/ version bump and "suspension" names

https://chromiumcodereview.appspot.com/1699153002/diff/100001/runtime/vm/serv...
File runtime/vm/service/service.md (right):

https://chromiumcodereview.appspot.com/1699153002/diff/100001/runtime/vm/serv...
runtime/vm/service/service.md:1216: // Is the isolate paused at an await
statement?
await, yield, yield*

https://chromiumcodereview.appspot.com/1699153002/diff/100001/runtime/vm/serv...
runtime/vm/service/service.md:2489: 3.2 | Isolate objects now include the
runnable bit and many debugger related RPCs will return an error if executed on
an isolate before it is runnable.
Bump minor version.

(Testing for 3.2 doesn't imply the VM supports OverAwait)

[Cutch, 2016-02-17 18:59:03]

https://chromiumcodereview.appspot.com/1699153002/diff/100001/runtime/vm/serv...
File runtime/vm/service/service.md (right):

https://chromiumcodereview.appspot.com/1699153002/diff/100001/runtime/vm/serv...
runtime/vm/service/service.md:1216: // Is the isolate paused at an await
statement?
On 2016/02/17 18:52:00, rmacnak wrote:
> await, yield, yield*

Done.

https://chromiumcodereview.appspot.com/1699153002/diff/100001/runtime/vm/serv...
runtime/vm/service/service.md:2489: 3.2 | Isolate objects now include the
runnable bit and many debugger related RPCs will return an error if executed on
an isolate before it is runnable.
On 2016/02/17 18:52:00, rmacnak wrote:
> Bump minor version.
> 
> (Testing for 3.2 doesn't imply the VM supports OverAwait)

Done.

[Cutch, 2016-02-17 19:02:59]

Description was changed from

==========
Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAsyncContinuation" boolean value.
- Resume command can take an 'OverAsyncContinuation' step mode.
- Breakpoints have an optional 'isSyntheticAsyncContinuation' boolean value.

Added low level step_over_await_test.

Issuing the OverAsyncContinuation resume command does the following:

- Adds a synthetic breakpoint (#1) to the async closure.
- Resumes the isolate.
- When we hit #1, the VM issues a StepOver and then reports us paused at #1.

At the next resume command, the VM will remove #1.
==========

to

==========
Add step OverAwait to service protocol

Additions to service protocol:

- PauseEvent includes an "atAsyncContinuation" boolean value.
- Resume command can take an 'OverAsyncContinuation' step mode.
- Breakpoints have an optional 'isSyntheticAsyncContinuation' boolean value.

Added low level step_over_await_test.

Issuing the OverAsyncContinuation resume command does the following:

- Adds a synthetic breakpoint (#1) to the async closure.
- Resumes the isolate.
- When we hit #1, the VM issues a StepOver and then reports us paused at #1.

At the next resume command, the VM will remove #1.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5c8d79c55a69c6a80072a8eb8307e7e38085357b
==========

[Cutch, 2016-02-17 19:03:00]

Committed patchset #8 (id:140001) manually as
5c8d79c55a69c6a80072a8eb8307e7e38085357b (presubmit successful).