[NTP Snippets] Schedule periodic fetching

chrome/android/javatests/src/org/chromium/chrome/browser/ChromeGcmTaskServiceTest.java

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ChromeGcmTaskServiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeGcmTaskServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeGcmTaskServiceTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..6e3fe91a27eacf21693399d8bd29019ecf00b99c
--- /dev/null
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeGcmTaskServiceTest.java
@@ -0,0 +1,127 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser;
+
+import android.content.Context;
+import android.test.InstrumentationTestCase;
+import android.test.suitebuilder.annotation.SmallTest;
+
+import com.google.android.gms.gcm.TaskParams;
+
+import org.chromium.base.ThreadUtils;
+import org.chromium.base.metrics.RecordHistogram;
+import org.chromium.base.test.util.AdvancedMockContext;
+import org.chromium.base.test.util.Feature;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsController;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsLauncher;
+
+/**
+ * Tests {@link ChromeGcmTaskService}.
+ */
+public class ChromeGcmTaskServiceTest extends InstrumentationTestCase {

[Bernhard Bauer, 2016/02/18 10:32:40]

Thanks for writing a test! I think it might be a bit easier though to do this as
a JUnit test. You can look around //chrome/android/junit for existing tests to
model it after.

[Marc Treib, 2016/02/18 10:52:40]

Ah, the diff is weird - I didn't actually write most of this, it was already
there as BackgroundSyncLauncherServiceTest. I just extended/generalized it a
bit. I'll defer to the BackgroundSync folks on why they chose an
InstrumentationTest (once May's stuff has landed).

[Bernhard Bauer, 2016/02/18 11:43:12]

Acknowledged.

+    private Context mContext;
+    private BackgroundSyncLauncher mSyncLauncher;
+    private SnippetsLauncher mSnippetsLauncher;
+    private MockSnippetsController mSnippetsController;
+    private MockTaskService mTaskService;
+
+    static class MockTaskService extends ChromeGcmTaskService {
+        private boolean mDidLaunchBrowser = false;
+
+        @Override
+        protected void launchBrowser(Context context) {
+            mDidLaunchBrowser = true;
+        }
+
+        // Posts an assertion task to the UI thread. Since this is only called after the call
+        // to onRunTask, it will be enqueued after any possible call to launchBrowser, and we
+        // can reliably check whether launchBrowser was called.
+        protected void checkExpectations(final boolean expectedLaunchBrowser) {
+            ThreadUtils.runOnUiThread(new Runnable() {
+                @Override
+                public void run() {
+                    assertEquals("StartedService", expectedLaunchBrowser, mDidLaunchBrowser);
+                }
+            });
+        }
+    }
+
+    static class MockSnippetsController extends SnippetsController {
+        private boolean mDidFetchSnippets = false;
+
+        MockSnippetsController() {
+            super(null);
+        }
+
+        @Override
+        public void fetchSnippets(boolean overwrite) {
+            mDidFetchSnippets = true;
+        }
+
+        protected void checkExpectations(final boolean expectedFetchSnippets) {
+            ThreadUtils.runOnUiThread(new Runnable() {
+                @Override
+                public void run() {
+                    assertEquals("FetchedSnippets", expectedFetchSnippets, mDidFetchSnippets);
+                }
+            });
+        }
+    }
+
+    @Override
+    protected void setUp() throws Exception {
+        mContext = new AdvancedMockContext(getInstrumentation().getTargetContext());
+        BackgroundSyncLauncher.setGCMEnabled(false);
+        RecordHistogram.disableForTests();
+        mSyncLauncher = BackgroundSyncLauncher.create(mContext);
+        mSnippetsLauncher = SnippetsLauncher.create(mContext);
+        mSnippetsController = new MockSnippetsController();
+        SnippetsController.setInstanceForTesting(mSnippetsController);
+        mTaskService = new MockTaskService();
+    }
+
+    private void deleteSyncLauncherInstance() {
+        mSyncLauncher.destroy();
+        mSyncLauncher = null;
+    }
+
+    private void deleteSnippetsLauncherInstance() {
+        mSnippetsLauncher.destroy();
+        mSnippetsLauncher = null;
+    }
+
+    private void startOnRunTaskAndVerify(String taskTag, boolean shouldStart,
+            boolean shouldFetchSnippets) {
+        mTaskService.onRunTask(new TaskParams(taskTag));
+        mTaskService.checkExpectations(shouldStart);
+        mSnippetsController.checkExpectations(shouldFetchSnippets);
+    }
+
+    @SmallTest
+    @Feature({"BackgroundSync"})
+    public void testBackgroundSyncNoLaunchBrowserWhenInstanceExists() {
+        startOnRunTaskAndVerify(BackgroundSyncLauncher.TASK_TAG, false, false);
+    }
+
+    @SmallTest
+    @Feature({"BackgroundSync"})
+    public void testBackgroundSyncLaunchBrowserWhenInstanceDoesNotExist() {
+        deleteSyncLauncherInstance();
+        startOnRunTaskAndVerify(BackgroundSyncLauncher.TASK_TAG, true, false);
+    }
+
+    @SmallTest
+    @Feature({"NTPSnippets"})
+    public void testNTPSnippetsNoLaunchBrowserWhenInstanceExists() {
+        startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG, false, true);
+    }
+
+    @SmallTest
+    @Feature({"NTPSnippets"})
+    public void testNTPSnippetsLaunchBrowserWhenInstanceDoesNotExist() {
+        deleteSnippetsLauncherInstance();
+        startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG, true, true);
+    }
+}