components/ntp_snippets/ntp_snippets_service_unittest.cc - Issue 1699143002: [NTP Snippets] Schedule periodic fetching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service_unittest.cc

Issue 1699143002: [NTP Snippets] Schedule periodic fetching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_feature

Patch Set: fix bots Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service_unittest.cc

diff --git a/components/ntp_snippets/ntp_snippets_service_unittest.cc b/components/ntp_snippets/ntp_snippets_service_unittest.cc

index f801e94680ba0f5c5d063eb43dfbbfb8c769f7e9..c845b1b89aa95e8b57c81925786924981e5135a0 100644

--- a/components/ntp_snippets/ntp_snippets_service_unittest.cc

+++ b/components/ntp_snippets/ntp_snippets_service_unittest.cc

@@ -61,7 +61,7 @@ class NTPSnippetsServiceTest : public testing::Test {

signin_client_.get(), account_tracker_.get());

scoped_ptr<NTPSnippetsService> service(

- new NTPSnippetsService(task_runner.get(), std::string("fr"),

+ new NTPSnippetsService(task_runner.get(), std::string("fr"), nullptr,

make_scoped_ptr(new NTPSnippetsFetcher(task_runner.get(),

signin_manager, token_service, request_context_getter,

base::FilePath()))));

@@ -75,7 +75,6 @@ class NTPSnippetsServiceTest : public testing::Test {

DISALLOW_COPY_AND_ASSIGN(NTPSnippetsServiceTest);

};

TEST_F(NTPSnippetsServiceTest, Create) {

scoped_ptr<NTPSnippetsService> service(CreateSnippetService());

EXPECT_FALSE(service->is_loaded());