Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java

Issue 1699143002: [NTP Snippets] Schedule periodic fetching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_feature
Patch Set: fix bots Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
index 55dd84cddfe5c06bf900d50b78db2903f04fc62e..e11d187ee091141c778b8e74869c978ccd015fc8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.ntp.snippets;
import android.content.Context;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.signin.SigninManager;
import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
@@ -20,7 +21,10 @@ public class SnippetsController implements SignInStateObserver {
private long mNativeSnippetsController;
public SnippetsController(Context applicationContext) {
- SigninManager.get(applicationContext).addSignInStateObserver(this);
+ // |applicationContext| can be null in tests.
+ if (applicationContext != null) {
+ SigninManager.get(applicationContext).addSignInStateObserver(this);
+ }
}
/**
@@ -55,5 +59,10 @@ public class SnippetsController implements SignInStateObserver {
@Override
public void onSignedOut() {}
+ @VisibleForTesting
+ public static void setInstanceForTesting(SnippetsController instance) {
+ sInstance = instance;
+ }
+
private native void nativeFetchSnippets(Profile profile, boolean overwrite);
}

Powered by Google App Engine
This is Rietveld 408576698