Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 1699143002: [NTP Snippets] Schedule periodic fetching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_feature
Patch Set: noyau review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_service.cc
diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc
index 66a923fe1e367cdc84df1e3f5a7338e637c392e3..98e823d23ea5ed77a8592cd06e94c30a81bd6129 100644
--- a/components/ntp_snippets/ntp_snippets_service.cc
+++ b/components/ntp_snippets/ntp_snippets_service.cc
@@ -12,7 +12,11 @@
#include "base/task_runner_util.h"
#include "base/values.h"
-namespace ntp_snippets {
+namespace {
+
+// TODO(crbug.com/587857): This is an extremely small value, for development.
+// Replace it by something sensible and add a command line param to control it.
+const int kDefaultFetchingIntervalSeconds = 60;
std::string ReadFileToString(const base::FilePath& path) {
std::string data;
@@ -22,13 +26,19 @@ std::string ReadFileToString(const base::FilePath& path) {
return data;
}
+} // namespace
+
+namespace ntp_snippets {
+
NTPSnippetsService::NTPSnippetsService(
scoped_refptr<base::SequencedTaskRunner> file_task_runner,
const std::string& application_language_code,
+ NTPSnippetsScheduler* scheduler,
scoped_ptr<NTPSnippetsFetcher> snippets_fetcher)
: loaded_(false),
file_task_runner_(file_task_runner),
application_language_code_(application_language_code),
+ scheduler_(scheduler),
snippets_fetcher_(std::move(snippets_fetcher)),
weak_ptr_factory_(this) {
snippets_fetcher_callback_ = snippets_fetcher_->AddCallback(
@@ -38,6 +48,17 @@ NTPSnippetsService::NTPSnippetsService(
NTPSnippetsService::~NTPSnippetsService() {}
+void NTPSnippetsService::Init(bool enabled) {
+ // The scheduler only exists on Android so far, it's null on other platforms.
+ if (!scheduler_)
+ return;
+
+ if (enabled)
+ scheduler_->Schedule(kDefaultFetchingIntervalSeconds);
+ else
+ scheduler_->Unschedule();
+}
+
void NTPSnippetsService::Shutdown() {
FOR_EACH_OBSERVER(NTPSnippetsServiceObserver, observers_,
NTPSnippetsServiceShutdown(this));

Powered by Google App Engine
This is Rietveld 408576698