Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1699113002: [test] Shard some slower bytecode graph builder tests. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
oth, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Shard some slower bytecode graph builder tests. This CL splits up some long-running bytecode graph builder tests. There's a lot of working going on here that probably should be split up into smaller tests and/or mjsunit tests once we have the full ignition pipeline. This one just targets the top offenders for now. R=rmcilroy@chromium.org, oth@chromium.org BUG= Committed: https://crrev.com/ccc33712642a403539e1c2cba6d8077443fdaa78 Cr-Commit-Position: refs/heads/master@{#34039}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -94 lines) Patch
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 50 chunks +66 lines, -94 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 10 months ago (2016-02-16 13:15:19 UTC) #1
rmcilroy
LGTM, thanks! https://codereview.chromium.org/1699113002/diff/1/test/cctest/compiler/test-run-bytecode-graph-builder.cc File test/cctest/compiler/test-run-bytecode-graph-builder.cc (right): https://codereview.chromium.org/1699113002/diff/1/test/cctest/compiler/test-run-bytecode-graph-builder.cc#newcode2610 test/cctest/compiler/test-run-bytecode-graph-builder.cc:2610: auto callable = tester.GetCallable<Handle<Object>>(); Thanks for spotting ...
4 years, 10 months ago (2016-02-16 14:06:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699113002/1
4 years, 10 months ago (2016-02-16 14:07:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 14:09:58 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 14:10:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccc33712642a403539e1c2cba6d8077443fdaa78
Cr-Commit-Position: refs/heads/master@{#34039}

Powered by Google App Engine
This is Rietveld 408576698