Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1699063002: Revert of Tweak type info threshold. (Closed)

Created:
4 years, 10 months ago by Jakob Kummerow
Modified:
4 years, 10 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Hablich, Benedikt Meurer, mvstanton, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Tweak type info threshold. (patchset #1 id:1 of https://codereview.chromium.org/1684093002/ ) Reason for revert: Tanks Mandreel-latency. Original issue's description: > Tweak type info threshold. > > Let the world know (if it cares) that this is the kind of > silliness that JS engines have to partake in if they want > to look good on Sunspider (this should give 5% overall). > > Committed: https://crrev.com/4f62af4234e8ad74abd8e4cd3e492f7727efc768 > Cr-Commit-Position: refs/heads/master@{#33866} TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/00b919cb115ef5fe6192915cc7f0e6c72585fff3 Cr-Commit-Position: refs/heads/master@{#34027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
Created Revert of Tweak type info threshold.
4 years, 10 months ago (2016-02-16 10:34:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699063002/1
4 years, 10 months ago (2016-02-16 10:35:07 UTC) #2
Yang
On 2016/02/16 10:35:07, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 10 months ago (2016-02-16 10:38:45 UTC) #3
Michael Achenbach
Thanks. FYI perf sheriffs.
4 years, 10 months ago (2016-02-16 10:46:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 10:59:44 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 11:00:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00b919cb115ef5fe6192915cc7f0e6c72585fff3
Cr-Commit-Position: refs/heads/master@{#34027}

Powered by Google App Engine
This is Rietveld 408576698