Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js

Issue 1699033003: dart2js cps: Combine integer type check with bounds check. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js
diff --git a/tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js b/tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js
index 6451f4bfde7fcf83438e29b3cb216c416b0e4d9f..1b8c35138749badff32658f8be2ccf05e66a17fb 100644
--- a/tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js
+++ b/tests/compiler/dart2js/cps_ir/expected/optimize_indexers.js
@@ -36,10 +36,8 @@
// }
function(data, x) {
- var v0 = J.$add$ns(x, 1), v1 = data.arr, v2 = v1.length;
- if (typeof x !== "number" || Math.floor(x) !== x)
- return H.iae(x);
- if (x < 0 || x >= v2)
+ var v0 = J.$add$ns(x, 1), v1 = data.arr;
+ if (x >>> 0 !== x || x >= v1.length)
return H.ioore(v1, x);
data.$indexSet(0, v0, v1[x]);
}
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart ('k') | tests/compiler/dart2js_extra/dart2js_extra.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698