Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1699033003: dart2js cps: Combine integer type check with bounds check. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update status Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/cps_ir/builtin_operator.dart ('K') | « pkg/compiler/lib/src/cps_ir/update_refinements.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart » ('j') | tests/compiler/dart2js_extra/dart2js_extra.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 38caa31158da4a88de1d072d0d22d2cdcf0142bf..1d2549d7ed4116569b3a2413ce37791b3616a5c7 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -1127,6 +1127,10 @@ class CodeGenerator extends tree_ir.StatementVisitor
return js.js('typeof # === "number" && Math.floor(#) === #', args);
case BuiltinOperator.IsNotInteger:
return js.js('typeof # !== "number" || Math.floor(#) !== #', args);
+ case BuiltinOperator.IsUnsigned32BitInteger:
+ return js.js('# >>> 0 === #', args);
+ case BuiltinOperator.IsNotUnsigned32BitInteger:
+ return js.js('# >>> 0 !== #', args);
case BuiltinOperator.IsFixedLengthJSArray:
// TODO(sra): Remove boolify (i.e. !!).
return js.js(r'!!#.fixed$length', args);
« pkg/compiler/lib/src/cps_ir/builtin_operator.dart ('K') | « pkg/compiler/lib/src/cps_ir/update_refinements.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart » ('j') | tests/compiler/dart2js_extra/dart2js_extra.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698