dart2js cps: Combine integer type check with bounds check.

dart2js cps: Combine integer type check with bounds check.

The lower bounds check can be combined with the argument check using a
uint32 check:

  if (i >>> 0 !== i || i >= array.length)
      return H.ioore(array, i);

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/e12baf93946ac057026e85cec07279f57d1cfb2b

[asgerf, 2016-02-16 11:01:45]

asgerf@google.com changed reviewers:
+ kmillikin@google.com, sigmund@google.com

[asgerf, 2016-02-16 11:01:45]

https://codereview.chromium.org/1699033003/diff/20001/tests/compiler/dart2js_...
File tests/compiler/dart2js_extra/dart2js_extra.status (left):

https://codereview.chromium.org/1699033003/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_extra/dart2js_extra.status:72:
consistent_index_error_string_test: RuntimeError # Expect.equals(at index 16:
Expected <...ument (index): ...>, Found: <...ument: "a">) fails.
It seem ioore and iae throw slightly different argument errors, and these tests
assert that the error is the one used by ioore.

[Siggi Cherem (dart-lang), 2016-02-16 16:52:16]

lgtm! really nice

https://codereview.chromium.org/1699033003/diff/20001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/builtin_operator.dart (right):

https://codereview.chromium.org/1699033003/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/builtin_operator.dart:152: /// Returns true if `x`
is an unsigned 32-bit integer.
true -> false (or 'is' -> 'is not')

[asgerf, 2016-02-17 08:33:09]

https://codereview.chromium.org/1699033003/diff/20001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/builtin_operator.dart (right):

https://codereview.chromium.org/1699033003/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/builtin_operator.dart:152: /// Returns true if `x`
is an unsigned 32-bit integer.
On 2016/02/16 16:52:16, Siggi Cherem (dart-lang) wrote:
> true -> false (or 'is' -> 'is not')

Thanks.

[asgerf, 2016-02-17 09:14:33]

Description was changed from

==========
dart2js cps: Combine integer type check with bounds check.

The lower bounds check can be combined with the argument check using a
uint32 check:

  if (i >>> 0 !== i || i >= array.length)
      return H.ioore(array, i);

BUG=
==========

to

==========
dart2js cps: Combine integer type check with bounds check.

The lower bounds check can be combined with the argument check using a
uint32 check:

  if (i >>> 0 !== i || i >= array.length)
      return H.ioore(array, i);

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e12baf93946ac057026e85cec07279f57d1cfb2b
==========

[asgerf, 2016-02-17 09:14:35]

Committed patchset #4 (id:60001) manually as
e12baf93946ac057026e85cec07279f57d1cfb2b (presubmit successful).