content/browser/BUILD.gn - Issue 1698933004: Make MediaSession a runtime-enabled feature on Desktop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/BUILD.gn

Issue 1698933004: Make MediaSession a runtime-enabled feature on Desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments and windows build fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/BUILD.gn

diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn

index 26fd1b1f8e2189e6f113f1a3fcc20e3fb9c0333d..a782d5271e5217fe56ab64c923c38fd878ee0dad 100644

--- a/content/browser/BUILD.gn

+++ b/content/browser/BUILD.gn

@@ -350,6 +350,7 @@ source_set("browser") {

"geolocation/network_location_provider.h",

"geolocation/network_location_request.cc",

"geolocation/network_location_request.h",

+ "media/session/media_session_delegate_default.cc",

whywhat 2016/03/01 03:12:10 nit: media_session_delegate_impl.cc? Seems like th

mlamouri (slow - plz ping) 2016/03/07 19:28:08 I wouldn't say that WMPI/WMPA is a common pattern.

"power_usage_monitor_impl.cc",

"power_usage_monitor_impl.h",

"renderer_host/begin_frame_observer_proxy.cc",

« no previous file with comments | « no previous file | content/browser/android/browser_jni_registrar.cc » ('j') | content/browser/media/media_web_contents_observer.h » ('J')