Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1698933002: Change mojo-helpers.js to support other test harnesses. (Closed)

Created:
4 years, 10 months ago by Sam McNally
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@service-registry-js-wrapper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change mojo-helpers.js to support other test harnesses. Also reimplement mojo_wait_for_incoming_message using mojo.support.asyncWait. Committed: https://crrev.com/0273a93590ff646f6753eaa98695b8868f013566 Cr-Commit-Position: refs/heads/master@{#376066}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 chunk +47 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Sam McNally
4 years, 10 months ago (2016-02-16 23:53:39 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-16 23:58:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698933002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698933002/100001
4 years, 10 months ago (2016-02-18 00:33:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 10 months ago (2016-02-18 02:19:12 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:20:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0273a93590ff646f6753eaa98695b8868f013566
Cr-Commit-Position: refs/heads/master@{#376066}

Powered by Google App Engine
This is Rietveld 408576698