Remove internal use of Document::defaultCharset

Remove internal use of Document::defaultCharset

This is in preparation for removing document.defaultCharset itself.

The third argument for FormDataBuilder::encodingFromAcceptCharset was
added in https://codereview.chromium.org/25417007 to handle a situation
where a form was inserted into an ImageDocument, which did not have an
encoding.

In https://codereview.chromium.org/1180793002 the charset attribute and
its aliases was made to never return null by initializing
DocumentEncodingData to UTF-8, and so the fallback to defaultCharset in
encodingFromAcceptCharset is now unreachable.

While in the area, clean up encodingFromAcceptCharset slightly to take
an explicit fallback encoding that must be valid, and use a range-based
for loop for readability.

TEST=LayoutTests/fast/images/image-page-injected-script-crash.html
BUG=567738
Committed: https://crrev.com/177c3bb89bc8072ac8b150e20a816b7e0f752802
Cr-Commit-Position: refs/heads/master@{#375835}

[philipj_slow, 2016-02-17 04:02:30]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 04:03:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698883005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698883005/1

[philipj_slow, 2016-02-17 04:04:16]

Description was changed from

==========
Remove internal use of Document::defaultCharset

This is in preparation for removing document.defaultCharset itself.

The third argument for FormDataBuilder::encodingFromAcceptCharset was
added in https://codereview.chromium.org/25417007 to handle a situation
where a form was inserted into an ImageDocument, which did not have an
encoding.

In https://codereview.chromium.org/1180793002 the charset attribute and
its aliases was made to never return null by initializing
DocumentEncodingData to UTF-8, and so the fallback to defaultCharset in
encodingFromAcceptCharset is now unreachable.

While in the area, clean up encodingFromAcceptCharset slightly to take
an explicit fallback encoding that must not be valid, and use a
range-based for loop for readability.

TEST=LayoutTests/fast/images/image-page-injected-script-crash.html
BUG=567738
==========

to

==========
Remove internal use of Document::defaultCharset

This is in preparation for removing document.defaultCharset itself.

The third argument for FormDataBuilder::encodingFromAcceptCharset was
added in https://codereview.chromium.org/25417007 to handle a situation
where a form was inserted into an ImageDocument, which did not have an
encoding.

In https://codereview.chromium.org/1180793002 the charset attribute and
its aliases was made to never return null by initializing
DocumentEncodingData to UTF-8, and so the fallback to defaultCharset in
encodingFromAcceptCharset is now unreachable.

While in the area, clean up encodingFromAcceptCharset slightly to take
an explicit fallback encoding that must be valid, and use a range-based
for loop for readability.

TEST=LayoutTests/fast/images/image-page-injected-script-crash.html
BUG=567738
==========

[commit-bot: I haz the power, 2016-02-17 05:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 05:10:55]

Dry run: This issue passed the CQ dry run.

[philipj_slow, 2016-02-17 05:15:41]

philipj@opera.com changed reviewers:
+ tkent@chromium.org

[philipj_slow, 2016-02-17 05:15:41]

PTAL

[tkent, 2016-02-17 06:58:01]

lgtm

[philipj_slow, 2016-02-17 08:56:37]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2016-02-17 08:57:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698883005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698883005/1

[commit-bot: I haz the power, 2016-02-17 09:04:37]

Description was changed from

==========
Remove internal use of Document::defaultCharset

This is in preparation for removing document.defaultCharset itself.

The third argument for FormDataBuilder::encodingFromAcceptCharset was
added in https://codereview.chromium.org/25417007 to handle a situation
where a form was inserted into an ImageDocument, which did not have an
encoding.

In https://codereview.chromium.org/1180793002 the charset attribute and
its aliases was made to never return null by initializing
DocumentEncodingData to UTF-8, and so the fallback to defaultCharset in
encodingFromAcceptCharset is now unreachable.

While in the area, clean up encodingFromAcceptCharset slightly to take
an explicit fallback encoding that must be valid, and use a range-based
for loop for readability.

TEST=LayoutTests/fast/images/image-page-injected-script-crash.html
BUG=567738
==========

to

==========
Remove internal use of Document::defaultCharset

This is in preparation for removing document.defaultCharset itself.

The third argument for FormDataBuilder::encodingFromAcceptCharset was
added in https://codereview.chromium.org/25417007 to handle a situation
where a form was inserted into an ImageDocument, which did not have an
encoding.

In https://codereview.chromium.org/1180793002 the charset attribute and
its aliases was made to never return null by initializing
DocumentEncodingData to UTF-8, and so the fallback to defaultCharset in
encodingFromAcceptCharset is now unreachable.

While in the area, clean up encodingFromAcceptCharset slightly to take
an explicit fallback encoding that must be valid, and use a range-based
for loop for readability.

TEST=LayoutTests/fast/images/image-page-injected-script-crash.html
BUG=567738
==========

[commit-bot: I haz the power, 2016-02-17 09:04:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 09:05:54]

Description was changed from

==========
Remove internal use of Document::defaultCharset

This is in preparation for removing document.defaultCharset itself.

The third argument for FormDataBuilder::encodingFromAcceptCharset was
added in https://codereview.chromium.org/25417007 to handle a situation
where a form was inserted into an ImageDocument, which did not have an
encoding.

In https://codereview.chromium.org/1180793002 the charset attribute and
its aliases was made to never return null by initializing
DocumentEncodingData to UTF-8, and so the fallback to defaultCharset in
encodingFromAcceptCharset is now unreachable.

While in the area, clean up encodingFromAcceptCharset slightly to take
an explicit fallback encoding that must be valid, and use a range-based
for loop for readability.

TEST=LayoutTests/fast/images/image-page-injected-script-crash.html
BUG=567738
==========

to

==========
Remove internal use of Document::defaultCharset

This is in preparation for removing document.defaultCharset itself.

The third argument for FormDataBuilder::encodingFromAcceptCharset was
added in https://codereview.chromium.org/25417007 to handle a situation
where a form was inserted into an ImageDocument, which did not have an
encoding.

In https://codereview.chromium.org/1180793002 the charset attribute and
its aliases was made to never return null by initializing
DocumentEncodingData to UTF-8, and so the fallback to defaultCharset in
encodingFromAcceptCharset is now unreachable.

While in the area, clean up encodingFromAcceptCharset slightly to take
an explicit fallback encoding that must be valid, and use a range-based
for loop for readability.

TEST=LayoutTests/fast/images/image-page-injected-script-crash.html
BUG=567738

Committed: https://crrev.com/177c3bb89bc8072ac8b150e20a816b7e0f752802
Cr-Commit-Position: refs/heads/master@{#375835}
==========

[commit-bot: I haz the power, 2016-02-17 09:05:55]

Patchset 1 (id:??) landed as
https://crrev.com/177c3bb89bc8072ac8b150e20a816b7e0f752802
Cr-Commit-Position: refs/heads/master@{#375835}