Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1698883004: Revert of Prefer to use the OES_depth24 extension for WebGL's depth-only back buffers. (Closed)

Created:
4 years, 10 months ago by phoglund_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prefer to use the OES_depth24 extension for WebGL's depth-only back buffers. (patchset #5 id:80001 of https://codereview.chromium.org/1675973002/ ) Reason for revert: Speculative revert: appears to break printing/webgl-oversized-printing.html on Linux MSAN: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8511 Original issue's description: > Prefer to use the OES_depth24 extension for WebGL's depth-only back buffers. > > Instead of using the OES_packed_depth_stencil extension to obtain 24-bit > depth buffers, prefer the OES_depth24 extension. This avoids a situation > where the depth buffer is cleared but the stencil buffer must be > preserved, leading to performance problems on some GPUs. > > BUG=584807 > > Committed: https://crrev.com/2374479265b26ba0a4a658582b068a4526220774 > Cr-Commit-Position: refs/heads/master@{#374562} TBR=bajones@chromium.org,zmo@chromium.org,marcheu@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -43 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 2 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 4 chunks +12 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund_chromium
Created Revert of Prefer to use the OES_depth24 extension for WebGL's depth-only back buffers.
4 years, 10 months ago (2016-02-16 10:15:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698883004/1
4 years, 10 months ago (2016-02-16 10:16:12 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/172830) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-16 10:18:43 UTC) #4
phoglund_chromium
On 2016/02/16 10:18:43, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-16 10:39:49 UTC) #5
phoglund_chromium
4 years, 10 months ago (2016-02-16 11:47:27 UTC) #6
On 2016/02/16 10:39:49, phoglund_chrome wrote:
> On 2016/02/16 10:18:43, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
> >   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
> >   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> Ok, that didn't work. I guess I have to revert some other patch first...

https://codereview.chromium.org/1698303002/ reverts both patches, closing this
one...

Powered by Google App Engine
This is Rietveld 408576698