Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: src/compiler/graph-trimmer.cc

Issue 1698883003: [turbofan] Robustify the GraphTrimmer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/graph-trimmer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/graph-trimmer.h" 5 #include "src/compiler/graph-trimmer.h"
6 6
7 #include "src/compiler/graph.h" 7 #include "src/compiler/graph.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
11 namespace compiler { 11 namespace compiler {
12 12
13 GraphTrimmer::GraphTrimmer(Zone* zone, Graph* graph) 13 GraphTrimmer::GraphTrimmer(Zone* zone, Graph* graph)
14 : graph_(graph), is_live_(graph, 2), live_(zone) { 14 : graph_(graph), is_live_(graph, 2), live_(zone) {
15 live_.reserve(graph->NodeCount()); 15 live_.reserve(graph->NodeCount());
16 } 16 }
17 17
18 18
19 GraphTrimmer::~GraphTrimmer() {} 19 GraphTrimmer::~GraphTrimmer() {}
20 20
21 21
22 void GraphTrimmer::TrimGraph() { 22 void GraphTrimmer::TrimGraph() {
23 // Mark end node as live. 23 // Mark end node as live.
24 MarkAsLive(graph()->end()); 24 MarkAsLive(graph()->end());
25 // Compute transitive closure of live nodes. 25 // Compute transitive closure of live nodes.
26 for (size_t i = 0; i < live_.size(); ++i) { 26 for (size_t i = 0; i < live_.size(); ++i) {
27 for (Node* const input : live_[i]->inputs()) MarkAsLive(input); 27 Node* const live = live_[i];
28 for (Node* const input : live->inputs()) MarkAsLive(input);
28 } 29 }
29 // Remove dead->live edges. 30 // Remove dead->live edges.
30 for (Node* const live : live_) { 31 for (Node* const live : live_) {
31 DCHECK(IsLive(live)); 32 DCHECK(IsLive(live));
32 for (Edge edge : live->use_edges()) { 33 for (Edge edge : live->use_edges()) {
33 Node* const user = edge.from(); 34 Node* const user = edge.from();
34 if (!IsLive(user)) { 35 if (!IsLive(user)) {
35 if (FLAG_trace_turbo_reduction) { 36 if (FLAG_trace_turbo_reduction) {
36 OFStream os(stdout); 37 OFStream os(stdout);
37 os << "DeadLink: " << *user << "(" << edge.index() << ") -> " << *live 38 os << "DeadLink: " << *user << "(" << edge.index() << ") -> " << *live
38 << std::endl; 39 << std::endl;
39 } 40 }
40 edge.UpdateTo(nullptr); 41 edge.UpdateTo(nullptr);
41 } 42 }
42 } 43 }
43 } 44 }
44 } 45 }
45 46
46 } // namespace compiler 47 } // namespace compiler
47 } // namespace internal 48 } // namespace internal
48 } // namespace v8 49 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/graph-trimmer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698