Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1698883003: [turbofan] Robustify the GraphTrimmer. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Robustify the GraphTrimmer. The GraphTrimmer should not ever see a dead node, except for the roots that are explicitly fed into it. To defend against this, turn the condition into a DCHECK. R=jarin@chromium.org Committed: https://crrev.com/86d1b7e83dc0fef3cc468eb62234a2d45ccb088e Cr-Commit-Position: refs/heads/master@{#34001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/compiler/graph-trimmer.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/graph-trimmer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-15 12:30:14 UTC) #1
Benedikt Meurer
Hey Jaro, Another small refactoring. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-15 12:31:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698883003/1
4 years, 10 months ago (2016-02-15 12:31:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 12:52:57 UTC) #6
Jarin
lgtm
4 years, 10 months ago (2016-02-15 15:16:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698883003/1
4 years, 10 months ago (2016-02-15 17:26:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 17:28:18 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 17:28:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86d1b7e83dc0fef3cc468eb62234a2d45ccb088e
Cr-Commit-Position: refs/heads/master@{#34001}

Powered by Google App Engine
This is Rietveld 408576698