Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 1698823002: X87: Preserve argument count for calls. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Preserve argument count for calls. port 5de27c343bbf898ca87246caa1e83e533ec44561(r33865) original commit message: Calls use registers for target, new_target and argument count. We don't always respect argument count. It didn't bite us in the past because the code paths where we clobbered it never used it, though in future it could be an issue. BUG= Committed: https://crrev.com/63a59fa34196a533defbb4ab5472a5bee5ffa38e Cr-Commit-Position: refs/heads/master@{#33984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-15 06:57:39 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-15 09:15:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698823002/1
4 years, 10 months ago (2016-02-15 09:16:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 09:45:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 09:46:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63a59fa34196a533defbb4ab5472a5bee5ffa38e
Cr-Commit-Position: refs/heads/master@{#33984}

Powered by Google App Engine
This is Rietveld 408576698