Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1698803002: X87: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods. port cfbd25617cfb8177bbb6377280e23ec356eb2373(r33857) original commit message: Preparing the young generation for (real) non-contiguous backing memory, this change removes object masks that are used to compute containment in semi and new space. The masks are replaced by lookups for object tags and page headers, where possible. Details: - Use the fast checks (page header lookups) for containment in regular code. - Use the slow version that masks out the page start adress and iterates all pages of a space for debugging/verification. - The slow version works for off-heap/unmapped memory. - Encapsulate all checks for the old->new barrier in Heap::RecordWrite(). BUG= Committed: https://crrev.com/d72bd65499c2cd43590ac4db30374878f2c71a47 Cr-Commit-Position: refs/heads/master@{#33970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M src/x87/macro-assembler-x87.cc View 1 chunk +6 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-15 06:14:22 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-15 06:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698803002/1
4 years, 10 months ago (2016-02-15 06:18:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 06:37:40 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 06:38:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d72bd65499c2cd43590ac4db30374878f2c71a47
Cr-Commit-Position: refs/heads/master@{#33970}

Powered by Google App Engine
This is Rietveld 408576698