Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1698763002: Fix base_nocompile_tests dependency (Closed)

Created:
4 years, 10 months ago by tzik
Modified:
4 years, 10 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix base_nocompile_tests dependency nocompile_tests wasn't aware header file dependencies that included by a .nc file. That makes a test failure sticky. This CL makes nocompile_driver.py to emit a depfile to let ninja know the implicit dependencies. Committed: https://crrev.com/b5f8f4bca759e2535439edb022cc1f3e0b5a897d Cr-Commit-Position: refs/heads/master@{#375504}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -25 lines) Patch
M build/nocompile.gni View 1 chunk +4 lines, -1 line 0 comments Download
M build/nocompile.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/nocompile_driver.py View 1 2 9 chunks +35 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tzik
PTAL
4 years, 10 months ago (2016-02-15 04:40:50 UTC) #2
Nico
lgtm https://codereview.chromium.org/1698763002/diff/20001/tools/nocompile_driver.py File tools/nocompile_driver.py (right): https://codereview.chromium.org/1698763002/diff/20001/tools/nocompile_driver.py#newcode197 tools/nocompile_driver.py:197: 'cmdline': The exectued command line. typo exectued->executed (not ...
4 years, 10 months ago (2016-02-15 12:28:53 UTC) #3
Nico
https://codereview.chromium.org/1698763002/diff/20001/tools/nocompile_driver.py File tools/nocompile_driver.py (right): https://codereview.chromium.org/1698763002/diff/20001/tools/nocompile_driver.py#newcode438 tools/nocompile_driver.py:438: cflags + ' -MMD -MF %s.d -MT %s' % ...
4 years, 10 months ago (2016-02-15 12:29:58 UTC) #4
tzik
https://codereview.chromium.org/1698763002/diff/20001/tools/nocompile_driver.py File tools/nocompile_driver.py (right): https://codereview.chromium.org/1698763002/diff/20001/tools/nocompile_driver.py#newcode197 tools/nocompile_driver.py:197: 'cmdline': The exectued command line. On 2016/02/15 12:28:53, Nico ...
4 years, 10 months ago (2016-02-16 01:25:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698763002/40001
4 years, 10 months ago (2016-02-16 01:25:55 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-16 02:34:53 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:51:08 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b5f8f4bca759e2535439edb022cc1f3e0b5a897d
Cr-Commit-Position: refs/heads/master@{#375504}

Powered by Google App Engine
This is Rietveld 408576698