Make the frame inspector use TranslatedState rather than the full deoptimizer.

Make the frame inspector use TranslatedState rather than the full deoptimizer.

This is mostly preparation for allowing the function closure to be materialized.

As a drive-by fix, I have added ignition source position support to the frame inspector (this fixed some ignition test failures).

Committed: https://crrev.com/54188964008a32edea8bd4a76c43313d2710043b
Cr-Commit-Position: refs/heads/master@{#33975}

[Jarin, 2016-02-13 19:15:28]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-13 19:15:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698743002/20001

[Jarin, 2016-02-13 19:32:25]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org, yangguo@chromium.org

[Jarin, 2016-02-13 19:32:26]

Could you take a look, please?

[commit-bot: I haz the power, 2016-02-13 19:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-13 19:34:30]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Jarin, 2016-02-13 19:44:29]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-13 19:44:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698743002/40001

[commit-bot: I haz the power, 2016-02-13 19:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-13 19:58:46]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13725)

[Jarin, 2016-02-14 20:20:19]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-14 20:20:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698743002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698743002/60001

[Jarin, 2016-02-14 20:24:12]

Patchset #4 (id:60001) has been deleted

[Jarin, 2016-02-14 20:28:24]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-14 20:28:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698743002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698743002/80001

[commit-bot: I haz the power, 2016-02-14 20:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-14 20:48:14]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-02-14 20:49:00]

Description was changed from

==========
Make the frame inspector use TranslatedState rather than the full deoptimizer.

This is mostly preparation for allowing the function closure to be materialized.
==========

to

==========
Make the frame inspector use TranslatedState rather than the full deoptimizer.

This is mostly preparation for allowing the function closure to be materialized.

As a drive-by fix, I have added ignition source position support to the frame
inspector (this fixed some ignition test failures).
==========

[Benedikt Meurer, 2016-02-15 05:48:26]

LGTM with nits.

https://codereview.chromium.org/1698743002/diff/80001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1698743002/diff/80001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:2543: DCHECK(parameter_count == parameters_count());
Nit: Remove this useless DCHECK.

https://codereview.chromium.org/1698743002/diff/80001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:2580: DCHECK(stack_it == frame_it->end());
Nit: Please use a CHECK here.

[Jarin, 2016-02-15 06:53:54]

Thanks, fixed the checks, also changed bunch of other dchecks into checks.

https://codereview.chromium.org/1698743002/diff/80001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1698743002/diff/80001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:2543: DCHECK(parameter_count == parameters_count());
On 2016/02/15 05:48:26, Benedikt Meurer wrote:
> Nit: Remove this useless DCHECK.

Done.

https://codereview.chromium.org/1698743002/diff/80001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:2580: DCHECK(stack_it == frame_it->end());
On 2016/02/15 05:48:26, Benedikt Meurer wrote:
> Nit: Please use a CHECK here.

Done.

[Jarin, 2016-02-15 06:53:58]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-02-15 06:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1698743002/#ps100001
(title: "Address review comments, changed some DCHECKs to CHECKs")

[commit-bot: I haz the power, 2016-02-15 06:54:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698743002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698743002/100001

[commit-bot: I haz the power, 2016-02-15 07:36:21]

Description was changed from

==========
Make the frame inspector use TranslatedState rather than the full deoptimizer.

This is mostly preparation for allowing the function closure to be materialized.

As a drive-by fix, I have added ignition source position support to the frame
inspector (this fixed some ignition test failures).
==========

to

==========
Make the frame inspector use TranslatedState rather than the full deoptimizer.

This is mostly preparation for allowing the function closure to be materialized.

As a drive-by fix, I have added ignition source position support to the frame
inspector (this fixed some ignition test failures).
==========

[commit-bot: I haz the power, 2016-02-15 07:36:22]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-02-15 07:37:07]

Description was changed from

==========
Make the frame inspector use TranslatedState rather than the full deoptimizer.

This is mostly preparation for allowing the function closure to be materialized.

As a drive-by fix, I have added ignition source position support to the frame
inspector (this fixed some ignition test failures).
==========

to

==========
Make the frame inspector use TranslatedState rather than the full deoptimizer.

This is mostly preparation for allowing the function closure to be materialized.

As a drive-by fix, I have added ignition source position support to the frame
inspector (this fixed some ignition test failures).

Committed: https://crrev.com/54188964008a32edea8bd4a76c43313d2710043b
Cr-Commit-Position: refs/heads/master@{#33975}
==========

[commit-bot: I haz the power, 2016-02-15 07:37:08]

Patchset 5 (id:??) landed as
https://crrev.com/54188964008a32edea8bd4a76c43313d2710043b
Cr-Commit-Position: refs/heads/master@{#33975}