third_party/WebKit/Source/platform/heap/ThreadState.cpp - Issue 1698703002: Disable page navigation GC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 1698703002: Disable page navigation GC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added bug no Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp

diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp

index 3d9554d46eca970a534c7103998220e3881ca990..ba95db76feddaf97e8bc640c2959b2285c123e41 100644

--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp

+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp

@@ -564,7 +564,8 @@ bool ThreadState::shouldScheduleV8FollowupGC()

bool ThreadState::shouldSchedulePageNavigationGC(float estimatedRemovalRatio)

{

- return judgeGCThreshold(1024 * 1024, 1.5 * (1 - estimatedRemovalRatio));

+ // TODO(keishi): Temporarily disabled to observe impact. crbug.com/588029

+ return false;

}

bool ThreadState::shouldForceConservativeGC()

« no previous file with comments | « no previous file | no next file » | no next file with comments »