Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1698563002: Provide a better type for line-splitter's bind. (Closed)

Created:
4 years, 10 months ago by floitsch
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M sdk/lib/convert/line_splitter.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
Add forgotten override to improve typing.
4 years, 10 months ago (2016-02-12 20:53:37 UTC) #2
Bob Nystrom
lgtm
4 years, 10 months ago (2016-02-12 21:03:34 UTC) #3
floitsch
4 years, 10 months ago (2016-02-12 21:04:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd2e5b8a75bbf5ca687b295c04edf3b05d9cf2d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698