Issue 169853002: (Pre)Parser: Move ParseExpression and ParseArrayLiteral to ParserBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 169853002: (Pre)Parser: Move ParseExpression and ParseArrayLiteral to ParserBase. (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

(Pre)Parser: Move ParseExpression and ParseArrayLiteral to ParserBase. Notes: - The functions already did the same thing -> no changes in logic. - One less glue function needed now. R=ulan@chromium.org BUG=v8:3126 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19469

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -111 lines)			Patch
M	src/parser.h	View	8 chunks	+9 lines, -7 lines	0 comments	Download
M	src/parser.cc	View	7 chunks	+7 lines, -56 lines	0 comments	Download
M	src/preparser.h	View	14 chunks	+92 lines, -6 lines	0 comments	Download
M	src/preparser.cc	View	3 chunks	+3 lines, -42 lines	0 comments	Download

Total messages: 3 (0 generated)

marja

ulan, ptal (but no hurry, I won't work on this until Wednesday)

6 years, 10 months ago (2014-02-17 16:56:33 UTC) #1

marja

6 years, 10 months ago (2014-02-19 08:56:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19469 (presubmit successful).